all: modernize source code; require go 1.24

cmd/globtest/main.go

@@ -103,15 +103,15 @@ func main() {
 
 	if *benchCompile {
 		b := testing.Benchmark(func(b *testing.B) {
-			for i := 0; i < b.N; i++ {
+			for b.Loop() {
 				glob.Compile(*pattern, separators...)
 			}
 		})
 		fmt.Fprintf(w, "compile:\t%s\n", benchString(b))
 	}
 	if *benchMatch {
 		b := testing.Benchmark(func(b *testing.B) {
-			for i := 0; i < b.N; i++ {
+			for b.Loop() {
 				g.Match(*fixture)
 			}
 		})

glob.go

@@ -146,7 +146,7 @@ func QuoteMeta(s string) string {
 	b := make([]byte, 2*len(s))
 	j := 0
 	// A byte loop is correct here because all meta characters are ASCII.
-	for i := 0; i < len(s); i++ {
+	for i := range len(s) {
 		if syntax.IsSpecial(s[i]) {
 			b[j] = '\\'
 			j++

glob_test.go

@@ -3,6 +3,7 @@ package glob
 import (
 	"errors"
 	"fmt"
+	"maps"
 	"path/filepath"
 	"regexp"
 	"slices"
@@ -879,15 +880,15 @@ func BenchmarkPattern(b *testing.B) {
 		},
 	} {
 		b.Run(test.name+"-compile", func(b *testing.B) {
-			for i := 0; i < b.N; i++ {
+			for b.Loop() {
 				MustCompile(test.pat)
 			}
 		})
 		pat := MustCompile(test.pat)
-		for _, key := range keysInOrder(test.input) {
+		for _, key := range slices.Sorted(maps.Keys(test.input)) {
 			str := test.input[key]
 			b.Run(test.name+"-match-"+key, func(b *testing.B) {
-				for i := 0; i < b.N; i++ {
+				for b.Loop() {
 					pat.Match(str)
 				}
 			})
@@ -1007,28 +1008,28 @@ func BenchmarkCompareGlobAndRegexp(b *testing.B) {
 		},
 	} {
 		b.Run(test.name+"-glob-compile", func(b *testing.B) {
-			for i := 0; i < b.N; i++ {
+			for b.Loop() {
 				MustCompile(test.glob)
 			}
 		})
 		b.Run(test.name+"-regexp-compile", func(b *testing.B) {
-			for i := 0; i < b.N; i++ {
+			for b.Loop() {
 				regexp.MustCompile(test.regexp)
 			}
 		})
 		var (
 			pat = MustCompile(test.glob)
 			exp = regexp.MustCompile(test.regexp)
 		)
-		for _, key := range keysInOrder(test.input) {
+		for _, key := range slices.Sorted(maps.Keys(test.input)) {
 			str := test.input[key]
 			b.Run(test.name+"-glob-"+key, func(b *testing.B) {
-				for i := 0; i < b.N; i++ {
+				for b.Loop() {
 					pat.Match(str)
 				}
 			})
 			b.Run(test.name+"-regexp-"+key, func(b *testing.B) {
-				for i := 0; i < b.N; i++ {
+				for b.Loop() {
 					exp.MatchString(str)
 				}
 			})
@@ -1127,12 +1128,3 @@ func TestPatternSeparatorsAliasing(t *testing.T) {
 		t.Errorf("Match() picked up the modification of the given slice")
 	}
 }
-
-func keysInOrder(m map[string]string) []string {
-	keys := make([]string, 0, len(m))
-	for key := range m {
-		keys = append(keys, key)
-	}
-	slices.Sort(keys)
-	return keys
-}

go.mod

@@ -1,3 +1,3 @@
 module github.com/gobwas/glob
 
-go 1.22.0
+go 1.24.0

syntax/lexer.go

@@ -365,7 +365,7 @@ reading:
 				escaped = true
 				continue
 			}
-			if slices.Index(breakers, r) != -1 {
+			if slices.Contains(breakers, r) {
 				l.unread()
 				break reading
 			}