Repository navigation
Fix plugin panics when retry body creation fails - #165
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
Keep the last request when GetBody fails so error plugins can read its URL and context. The bundled request logger otherwise panics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
Keep the last request when GetBody fails during a retry.
Error plugins can now read its URL and context, and the bundled request logger returns normally instead of panicking.
The body error still reaches the caller, together with any earlier transport errors.
Four regression cases cover first and later retries after transport errors and HTTP 503 responses.
Each reproduces the logger panic on upstream and passes with the fix.
Checked in Docker with Go 1.25.14 using make setup and make test.
The build, pinned golangci-lint 2.8.0 and all race tests pass.
Fixes #164.