Skip to content

Use bazelisk for amd64 as well - #2981

Open
0405ysj wants to merge 1 commit into
google:mainfrom
0405ysj:bazel_fix
Open

Use bazelisk for amd64 as well#2981
0405ysj wants to merge 1 commit into
google:mainfrom
0405ysj:bazel_fix

Conversation

@0405ysj

@0405ysj 0405ysj commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 6, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 6, 2026
@0405ysj
0405ysj requested review from ikicha and k311093 August 6, 2026 08:09
3405691582 added a commit to 3405691582/android-cuttlefish that referenced this pull request Aug 6, 2026
We curl this URL, which is now broken. google#2981 is considering using
bazelisk, but the scripts and presubmits are broken now, so we should
fix this now.
3405691582 added a commit that referenced this pull request Aug 6, 2026
We curl this URL, which is now broken. #2981 is considering using
bazelisk, but the scripts and presubmits are broken now, so we should
fix this now.
Databean pushed a commit to Databean/android-cuttlefish that referenced this pull request Aug 6, 2026
We curl this URL, which is now broken. google#2981 is considering using
bazelisk, but the scripts and presubmits are broken now, so we should
fix this now.
@0405ysj
0405ysj force-pushed the bazel_fix branch 2 times, most recently from 6fe02b9 to 209b5b2 Compare August 7, 2026 01:55
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 7, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 7, 2026
rmuthiah pushed a commit that referenced this pull request Aug 7, 2026
We curl this URL, which is now broken. #2981 is considering using
bazelisk, but the scripts and presubmits are broken now, so we should
fix this now.
0405ysj pushed a commit to 0405ysj/android-cuttlefish that referenced this pull request Aug 13, 2026
We curl this URL, which is now broken. google#2981 is considering using
bazelisk, but the scripts and presubmits are broken now, so we should
fix this now.
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 20, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 20, 2026
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 20, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 20, 2026
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 20, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 20, 2026
cjreynol pushed a commit that referenced this pull request Aug 21, 2026
We curl this URL, which is now broken. #2981 is considering using
bazelisk, but the scripts and presubmits are broken now, so we should
fix this now.
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 24, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 24, 2026
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 24, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 24, 2026
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 24, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 24, 2026
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 24, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 24, 2026
@0405ysj
0405ysj marked this pull request as ready for review August 24, 2026 22:56
@0405ysj
0405ysj requested review from Databean and jemoreira August 24, 2026 22:56
@Databean

Copy link
Copy Markdown
Member

@monkey-jsun has been working on building/running the host tools on riscv64, and it looks like the bazelisk .debs published on https://www.github.com/bazelbuild/bazelisk/releases are currently only for amd64 and arm64, is this going to cause breakage?

@0405ysj

0405ysj commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator Author

@monkey-jsun has been working on building/running the host tools on riscv64, and it looks like the bazelisk .debs published on https://www.github.com/bazelbuild/bazelisk/releases are currently only for amd64 and arm64, is this going to cause breakage?

I think it's out of scope of this PR? So far, installbazel.sh have supported amd64 and arm64 only. I don't expect we can use this script for riscv64 without any modification.

@Databean

Copy link
Copy Markdown
Member

The possibly breaking change is that this PR updates base/debian/control to depend on a package that is not in debian upstream, and for which no riscv64 equivalent is published.

@monkey-jsun

Copy link
Copy Markdown
Contributor

My temporary solution for riscv64 is to give instruction on building riscv64 by yourself and bail out early.

7ed7202

(ignore the polluted marker lines)

@0405ysj

0405ysj commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks for sharing how riscv64 will install bazel. I updated base/debian/control.

@0405ysj 0405ysj changed the title Use bazelisk for all archs Use bazelisk for amd64 as well Aug 26, 2026
@0405ysj 0405ysj added the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 26, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Aug 26, 2026
@Databean

Copy link
Copy Markdown
Member

Sorry, also comes to mind that @grandpaul is working on a strategy to make this build self-contained where bazel comes only from the repo and the source dependencies are vendored, does this conflict?

Can't think of issues beyond that.

@0405ysj

0405ysj commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator Author

Sorry, also comes to mind that @grandpaul is working on a strategy to make this build self-contained where bazel comes only from the repo and the source dependencies are vendored, does this conflict?

Can't think of issues beyond that.

No worries, checking everything is important than just merging PR, especially for this one.

I don't know Paul's strategy yet though, I believe the new strategy wouldn't be keeping diverged bazel installation mechanism between arch.(bazel for amd64, bazelisk for arm64) Not yet certain if the direction should be applying bazelisk on amd64 or dropping bazelisk on arm64, depending on his answer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants