Align J2ObjC enum Swift naming with J2KT and update call-sites. - #2818
Open
copybara-service[bot] wants to merge 1 commit into
Open
Align J2ObjC enum Swift naming with J2KT and update call-sites.#2818copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_953473715
branch
from
July 24, 2026 19:27
186c5be to
a4b29a9
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_953473715
branch
3 times, most recently
from
July 27, 2026 15:26
eff0cd8 to
a67ec01
Compare
When using @SwiftName on Java enums, J2ObjC used to swap the Swift names for the typedef NS_ENUM and the class interface compared to J2KT. This change updates J2ObjC to emit NS_SWIFT_NAME(Name_Enum) on typedef NS_ENUM and NS_SWIFT_NAME(Name) on class interface, matching J2KT. PiperOrigin-RevId: 953473715
copybara-service
Bot
force-pushed
the
test_953473715
branch
from
July 27, 2026 16:41
a67ec01 to
9c574c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align J2ObjC enum Swift naming with J2KT and update call-sites.
When using @SwiftName on Java enums, J2ObjC used to swap the Swift names for the typedef NS_ENUM and the class interface compared to J2KT.
This change updates J2ObjC to emit NS_SWIFT_NAME(Name_Enum) on typedef NS_ENUM and NS_SWIFT_NAME(Name) on class interface, matching J2KT.