Skip to content

Cast numeric parameters to float in distributions_are_equal before comparing. #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cast numeric parameters to float in distributions_are_equal before comparing. #1743

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions meridian/model/prior_distribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,12 +1247,19 @@ def distributions_are_equal(
if a_params.keys() != b_params.keys():
return False

def _maybe_cast_to_float(val):
dtype = getattr(val, 'dtype', type(val))
if 'int' in backend.standardize_dtype(dtype):
return backend.to_tensor(val, dtype=backend.float_dtype)
return val

for key in a_params.keys():
if isinstance(
a_params[key], (backend.Tensor, np.ndarray, float, int)
) and isinstance(b_params[key], (backend.Tensor, np.ndarray, float, int)):
a_val = backend.cast(a_params[key], backend.float_dtype)
b_val = backend.cast(b_params[key], backend.float_dtype)
a_val = _maybe_cast_to_float(a_params[key])
b_val = _maybe_cast_to_float(b_params[key])

if not backend.allclose(a_val, b_val):
return False
else:
Expand Down
Loading