ci(EN-11822): make build and test targets CI-ready - #48
Merged
Merged
Conversation
Split the Makefile into developer entry points and leaf targets. The entry points keep their existing prerequisite chains; the leaf targets declare none, so CI can install once with npm ci and run each step without npm install running again. ci-unit-test writes a JUnit report for CircleCI Test Insights.
philgebhardt
approved these changes
Sep 22, 2026
ZachNo
approved these changes
Sep 22, 2026
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Refactors build and test targets for independent CI execution while preserving developer workflows.
Changes:
- Adds CI-specific install and JUnit test targets.
- Separates typechecking, bundling, and compilation steps.
- Ignores generated build files and test reports.
| File | Summary |
|---|---|
tsconfig.json |
Excludes dependency and generated build directories. |
Makefile |
Adds CI-ready installation, build, and test targets. |
.gitignore |
Ignores generated test reports. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the Makefile into developer entry points and no-prerequisite leaf
targets, so CircleCI can install once and run each step independently.
ci-install—npm citypecheck,bundle,compile— build steps, no install prerequisiteunit-test/ci-unit-test— the latter adds a JUnit report for Test Insightsinstall,build,testandpublishare unchanged.No version bump for this change.