Conversation
Pyatakov
force-pushed
the
chore/migrate-tslint-to-eslint
branch
from
July 3, 2026 12:43
6b2374f to
c07e50f
Compare
Test Results 32 files 64 suites 4m 6s ⏱️ For more details on these failures, see this check. Results for commit c6be66f. ♻️ This comment has been updated with latest results. |
Pyatakov
force-pushed
the
chore/migrate-tslint-to-eslint
branch
from
July 3, 2026 12:53
c07e50f to
0ce2a66
Compare
Pyatakov
force-pushed
the
chore/migrate-tslint-to-eslint
branch
from
July 3, 2026 15:36
0ce2a66 to
365e001
Compare
Pyatakov
force-pushed
the
chore/migrate-tslint-to-eslint
branch
3 times, most recently
from
July 15, 2026 21:49
70f5c9e to
8fab39f
Compare
Pyatakov
force-pushed
the
chore/migrate-tslint-to-eslint
branch
3 times, most recently
from
August 17, 2026 22:56
af68761 to
86501ad
Compare
Replace end-of-life TSLint with ESLint 10 using a single flat config at the repo root (eslint.config.mjs). Rules are ported from tslint.json to keep coverage equivalent (quotes, eqeqeq, curly, no-bitwise, no-shadow, unused vars, kebab-case filenames, etc.); formatting is handled by @Stylistic rather than Prettier. - Remove tslint.json files, tslint dependencies, and per-package lint scripts; add root lint and lint:fix scripts. - Replace the per-package CI lint loop with a single yarn lint step. - Ignore packages not previously enforced in CI and test files, to be cleaned up and re-enabled incrementally. Signed-off-by: Alex Piatakov <alex.piatakov@swirldslabs.com>
Signed-off-by: Alex Piatakov <alex.piatakov@hashgraph.com>
Signed-off-by: Alex Piatakov <alex.piatakov@hashgraph.com>
Pyatakov
force-pushed
the
chore/migrate-tslint-to-eslint
branch
from
August 17, 2026 23:38
86501ad to
c6be66f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
eslint.config.mjs) built withdefineConfigand presetextends.eslint:recommendedandtypescript-eslintrecommended, keeping the TSLint rules no preset covers (eqeqeq,curly,no-var,no-throw-literal,no-shadow, kebab-case filenames and the@stylisticformatting group). Formatting is enforced through@stylisticrather than Prettier, so no mass reformat is needed.eslint-plugin-unicornone rule at a time rather than through a preset. The presets enable roughly 200 rules, of which several emit incorrect code when autofixed:no-new-arraydrops the generic type argument and breaks the build, andno-useless-coercionstripsString()from the non-string branch of atypeofcheck, silently changing hash inputs. Listing rules explicitly also keeps plugin upgrades from enabling new rules unreviewed.max-classes-per-file,no-bitwise,default-case,dot-notation,no-caller,object-shorthand,one-varandyoda.no-explicit-anyandno-undefoff, matching TSLint: the former reports 5,449 violations, and the latter only false-positives on TypeScript-only global types.tslint.jsonfiles, thetslint/tslint-config-standarddependencies and the per-packagelintscripts; add rootlintandlint:fixscripts.yarn lintstep.eslint --fixacross the in-scope packages.1,039 violations remain and are not yet addressed, so the lint step is expected to fail until they are.