Repository navigation
feat: expose resolved MSVC and Windows SDK versions - #13
Merged
Merged
Conversation
ArchangelX360
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Consumers currently have to repeat MSVC toolset, compiler-compatibility, redistributable, Windows SDK package, and SDK include-tree versions outside the repositories that resolve them. Those copies can drift when the configured Microsoft payloads change.
Contract
The generated
@msvc_runtimeand@windows_sdkrepositories are the authoritative source for their resolved versions. Consumers can load public Starlark constants instead of reconstructing paths or hard-coding versions.MSVC 14.x toolset versions map to their corresponding 19.x compiler compatibility version. The repository rule validates this supported format rather than silently deriving an unknown future mapping. Redistributable and SDK include versions remain independently discovered from the extracted payloads.
Change
@msvc_runtime//:versions.bzlwithMSVC_TOOLSET_VERSION,MSVC_COMPATIBILITY_VERSION, andVC_REDIST_VERSION;@windows_sdk//:versions.bzlwithWINDOWS_SDK_VERSIONandWINDOWS_SDK_INCLUDE_VERSION;Tests
bazel test --repo_env=BAZEL_MSVC_RUNTIME_VISUAL_STUDIO_EULA=1 //:smoke_test //:resolved_versions_testfrome2e/smokebazel test //:registered_msvc_runtime_extension_without_eula_testfrome2e/msvc_runtime_lazybazel test //...bazel run //.github/workflows:buildifier.checkbazel run //:gazelle -- -mode=diff