Skip to content

Feat/operator dashboard - #741

Closed
jeandemeusy wants to merge 2 commits into
hoprnet:mainfrom
jeandemeusy:feat/operator-dashboard
Closed

jeandemeusy wants to merge 2 commits into
hoprnet:mainfrom
jeandemeusy:feat/operator-dashboard

Conversation

@jeandemeusy

Copy link
Copy Markdown

No description provided.

@jeandemeusy jeandemeusy closed this Oct 6, 2026

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs Reviewer Agent📚

Review completed with 4 suggestions.

Reviewed commit: fc7a1ab

Comment thread src/theme/tokens.ts
@@ -0,0 +1,122 @@
// Design tokens. Single source for the MUI theme and the CSS custom properties
// (see GlobalTokens), so emotion components and MUI components stay in sync.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs Reviewer Agent📚

This comment points contributors to GlobalTokens, but no symbol by that name exists — the CSS custom properties are emitted by the MUI <GlobalStyles> element inside AppThemeProvider (src/theme/index.tsx).

Suggested change
// (see GlobalTokens), so emotion components and MUI components stay in sync.
// (see GlobalStyles in ./index.tsx), so emotion components and MUI components stay in sync.

Severity: low


🤖 Was this useful? React with 👍 or 👎

disableScrollLock
>
<Hint>
Data refreshes every 60 s.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs Reviewer Agent📚

This hint states a flat refresh interval, but sessions are polled every 20 s (useWatcher/index.ts) and metrics are polled every 15 s while the Health page is open, so "every 60 s" understates what many operators will observe.

Suggested change
Data refreshes every 60 s.
Data refreshes automatically.

Severity: low


🤖 Was this useful? React with 👍 or 👎

# GitHub Workflows

This document describes the GitHub workflows used in this project.
All tools (Node.js, yarn, actionlint, zizmor, gh) come from the flake's `ci*` dev shells; jobs run their steps through

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs Reviewer Agent📚

This states that all jobs run their steps through nix develop .#ci-node<version>, but the "Lint workflows" job in checks.yaml runs through .#ci and the jobs in docker.yaml use no nix shell at all, so the blanket claim misleads when editing those workflows.

Suggested change
All tools (Node.js, yarn, actionlint, zizmor, gh) come from the flake's `ci*` dev shells; jobs run their steps through
All tools (Node.js, yarn, actionlint, zizmor, gh) come from the flake's `ci*` dev shells; the build/lint/test and release steps run through
`nix develop .#ci-node<version> --command …` (the workflow-lint job uses `.#ci`), so CI uses exactly the toolchain you get locally with `nix develop`.

Severity: low


🤖 Was this useful? React with 👍 or 👎

* Callback function called when the CSV data is successfully parsed.
* @param data The parsed data as an array of objects.
*/
onParse: (data: T[]) => void;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs Reviewer Agent📚

These JSDoc blocks ("Props for the CSVUploader component.", "@param data The parsed data as an array of objects.") only restate what the CSVUploaderProps<T> type already declares, adding noise a reader must skip past.

Suggested change
onParse: (data: T[]) => void;
type CSVUploaderProps<T extends ParsedData> = {
onParse: (data: T[]) => void;
};

Severity: low


🤖 Was this useful? React with 👍 or 👎

@jeandemeusy
jeandemeusy deleted the feat/operator-dashboard branch October 6, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant