Repository navigation
Feat/operator dashboard - #741
jeandemeusy wants to merge 2 commits into
Conversation
| @@ -0,0 +1,122 @@ | |||
| // Design tokens. Single source for the MUI theme and the CSS custom properties | |||
| // (see GlobalTokens), so emotion components and MUI components stay in sync. | |||
There was a problem hiding this comment.
This comment points contributors to GlobalTokens, but no symbol by that name exists — the CSS custom properties are emitted by the MUI <GlobalStyles> element inside AppThemeProvider (src/theme/index.tsx).
| // (see GlobalTokens), so emotion components and MUI components stay in sync. | |
| // (see GlobalStyles in ./index.tsx), so emotion components and MUI components stay in sync. |
Severity: low
🤖 Was this useful? React with 👍 or 👎
| disableScrollLock | ||
| > | ||
| <Hint> | ||
| Data refreshes every 60 s. |
There was a problem hiding this comment.
This hint states a flat refresh interval, but sessions are polled every 20 s (useWatcher/index.ts) and metrics are polled every 15 s while the Health page is open, so "every 60 s" understates what many operators will observe.
| Data refreshes every 60 s. | |
| Data refreshes automatically. |
Severity: low
🤖 Was this useful? React with 👍 or 👎
| # GitHub Workflows | ||
|
|
||
| This document describes the GitHub workflows used in this project. | ||
| All tools (Node.js, yarn, actionlint, zizmor, gh) come from the flake's `ci*` dev shells; jobs run their steps through |
There was a problem hiding this comment.
This states that all jobs run their steps through nix develop .#ci-node<version>, but the "Lint workflows" job in checks.yaml runs through .#ci and the jobs in docker.yaml use no nix shell at all, so the blanket claim misleads when editing those workflows.
| All tools (Node.js, yarn, actionlint, zizmor, gh) come from the flake's `ci*` dev shells; jobs run their steps through | |
| All tools (Node.js, yarn, actionlint, zizmor, gh) come from the flake's `ci*` dev shells; the build/lint/test and release steps run through | |
| `nix develop .#ci-node<version> --command …` (the workflow-lint job uses `.#ci`), so CI uses exactly the toolchain you get locally with `nix develop`. |
Severity: low
🤖 Was this useful? React with 👍 or 👎
| * Callback function called when the CSV data is successfully parsed. | ||
| * @param data The parsed data as an array of objects. | ||
| */ | ||
| onParse: (data: T[]) => void; |
There was a problem hiding this comment.
These JSDoc blocks ("Props for the CSVUploader component.", "@param data The parsed data as an array of objects.") only restate what the CSVUploaderProps<T> type already declares, adding noise a reader must skip past.
| onParse: (data: T[]) => void; | |
| type CSVUploaderProps<T extends ParsedData> = { | |
| onParse: (data: T[]) => void; | |
| }; |
Severity: low
🤖 Was this useful? React with 👍 or 👎
No description provided.