Repository navigation
Conversation
Container labels with a '/' in the key (e.g. Kubernetes/OCI-style namespaced labels like nuclio.io/function-spec) produce an invalid Prometheus label name such as container_label_nuclio_io/function_spec. A raw '/' is not valid in a Prometheus label name, so this breaks parsing of the whole /metrics response for scrapers that enforce the exposition format strictly (observed with Grafana Alloy), losing every metric from that target, not just the offending one. Add '/' to the existing escape_list alongside '-', '.', ':' and ' '.
jaimeib
force-pushed
the
fix/container-label-slash-escaping
branch
from
September 19, 2026 14:25
f185c70 to
cec9162
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #439
Container labels with a
/in the key (e.g. Kubernetes/OCI-style namespaced labels likenuclio.io/function-spec) produce an invalid Prometheus label name such ascontainer_label_nuclio_io/function_spec, since a raw/isn't valid in a Prometheus label name.This breaks parsing of the whole
/metricsresponse for scrapers that enforce the exposition format strictly (observed with Grafana Alloy), losing every metric from that target, not just the offending one.The fix adds
/to the existingescape_listalongside-,.,:andProcessTracker's container label handling, so the key becomescontainer_label_nuclio_io_function_spec— a single-line change.