Repository navigation
fix(cli): six small faults from the walkthrough - #653
Merged
Merged
Conversation
- /about says CLOSED on weekends and holidays and after an early close, by the calendar the routines use, and names the real next session - /about, --help and the fallback URL carry the project's name - the empty /watchlist message names the real command - restoring trailing stops skips a user's own trailing trigger, so its false "Incomplete" warning goes - the buy-override prompt shows the BUY it would place, with its stop below the price, and no longer offers `short`, which the CLI refuses - a stop at the broker prints once, at the broker's price; saved levels fill in only what the broker lacks Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six faults from the offline CLI walkthrough and the guarded model check. Nothing here changes an order, a stop or a routine's actions.
Fixed
/aboutmarket status. It said OPEN from 09:30 to 16:00 ET every day, including weekends and holidays, and ignored early closes. It now usesget_market_hours_for_date, the calendar the routines use, and names the next session ("Opens Mon Nov 02, 09:30 AM ET")./about,main.py --helpand the fallback URL now say OptionsCommander./watchlistwith no lists names/watchlist create NAME.Direction: SELL (SHORT)and a stop above the price before asking. The prompt now shows the BUY it would place. Declining no longer suggestsshort, which the CLI refuses.what's my stop on SPY?printed STOP LOSS twice. A stop at the broker now prints once, at the broker's price; saved levels only fill in what the broker lacks.Testing
Mocks and a temp GTT database; no broker or model calls. The tests for these faults fail on the old code.
pytest tests/ -m "not db": 1943 passed, 2 skipped.