Skip to content

refactor(cli): drop the tool objects the agents needed; closes #331 - #657

Merged
iAmGiG merged 1 commit into
developmentfrom
refactor/retire-tool-layer-331
Nov 1, 2026
Merged

iAmGiG merged 1 commit into
developmentfrom
refactor/retire-tool-layer-331

Conversation

@iAmGiG

@iAmGiG iAmGiG commented Nov 1, 2026

Copy link
Copy Markdown
Owner

With the agents gone (#656), nothing used this layer. The CLI calls plain functions, as it already did. The commands that replaced what only tools could do merged in #655.

Removed

  • FunctionTool objects, the tool registry and the approval flags. No agent is left to ask for approval; the CLI's own prompts are unchanged.
  • User price alerts: they never fired and no routine checked them. /gtt has working alerts.
  • Portfolio overrides: nothing read them, including src/trading/portfolio_override.py.
  • Account display wrappers and voter explainers, which commands already cover.
  • TrailingStopCommands, which was never wired up; /trailing is the view now.
  • Functions only an agent could reach, and the AutoGenLLMParser alias.

No data goes with them: the real state/user.db has no user_alerts or portfolio_overrides table.

Guarded

Only src/parsers/llm_parser.py imports the agent framework now, and test_llm_is_the_parser_only.py holds it there. Both dependencies stay, for the parser.

Testing

pytest tests/ -m "not db": 1903 passed, 1 skipped. Guarded real CLI run with temp state and a copy of user.db: 15 commands and 7 typed requests, 5 model calls, no blocked hosts and no order attempts. The real user.db was untouched.

Closes #331

With the agents gone nothing used them. The CLI calls plain functions.

- removed: FunctionTool objects, the registry and approval flags
- removed: user price alerts (they never fired; /gtt has working alerts),
  portfolio overrides (nothing read them), the account display wrappers and
  voter explainers (commands cover them), TrailingStopCommands (never wired up)
- removed: functions only an agent could reach
- only the natural-language parser imports the agent framework now, and a test
  holds it there

Closes #331

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agents: make one tool round trip reachable from the CLI, or retire the dormant agent code

1 participant