Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
presentdiffs the previous frame's layers against the new ones to find the damage. Both sets of bounds are in logical units, and the frame only records its background colour, so a change ofApplication::scale_factorleaves anything whose logical bounds did not move undamaged. Those pixels stay on screen at the old scale while text and moved widgets are drawn at the new one: backgrounds, borders and button fills end up offset from their labels until something repaints the whole window.The window's own DPI change does not hit this, because
WindowEvent::ScaleFactorChangedbumpssurface_versionandconfigure_surfaceclears the frames.State::synchronizeupdates the viewport for a new application scale factor without doing that.Repro: an app whose
scale_factorcomes from its state (a zoom), run withICED_BACKEND=tiny-skia, change the zoom. The wgpu backend redraws every frame and is not affected.Fix: keep the scale factor in
Frameand compare it together with the background, the same way a background change already forces a full redraw.