Repository navigation
feat: add skill short description and overview presentation fields (#1035, part 1) - #1043
Open
xiaoyaner0201 wants to merge 4 commits into
Open
xiaoyaner0201 wants to merge 4 commits into
xiaoyaner0201 wants to merge 4 commits into
Conversation
Signed-off-by: 千乘妍 (Xiaoyaner) <xiaoyaner0201@users.noreply.github.com>
Signed-off-by: 千乘妍 (Xiaoyaner) <xiaoyaner0201@users.noreply.github.com>
…ance Signed-off-by: 千乘妍 (Xiaoyaner) <xiaoyaner0201@users.noreply.github.com>
Signed-off-by: 千乘妍 (Xiaoyaner) <xiaoyaner0201@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First slice of #1035, following the boundaries agreed in #1035 (comment): user-facing presentation fields. Homepage featured picks will come in a separate PR.
shortDescription,overview,resetPresentation) orSKILL.mdmetadata (metadata.short-description,metadata.overview) for CLI publishing. Explicit web values win. The uploaded package andSKILL.mdare never rewritten.parsedMetadataJson) likedisplayNameOverridefrom feat(publish): support version-consistent skill display names #957 — no DB migration.description; overview → README → SKILL.md.presentationInheritedFrom, and stays fixed for that submission. Default state is stored empty, so later versions read their own package defaults (old default text is never copied as custom).descriptionis kept insearch_text, so existing retrieval still works. Overview is not indexed.docs/07), lifecycle (docs/14), search (docs/04), CLI README; OpenSpec changeadd-skill-presentation-fields; regenerated OpenAPI types; en/zh translations.Validation
./mvnw -pl skillhub-domain -am test): all pass, including new tests for inheritance, frozen inheritance, default-not-copied, restore-default, pending isolation, approval, yank, promotion, rerelease, length limits and snapshots with extra fields.make typecheck-web,make lint-web,make test-frontend(1,362 tests) and build: pass.make test-backend-app: on this machine the only failures (1,526 run: 3 failures, 1 error) are GitHub-sync concurrency/integration tests whose failing set changes run to run; the same command on the untouched base326cbd62also fails there (5 failures, 10 errors). Everything else passes. Leaving CI as the referee.Risk
Notes
RECOMMENDEDlabel).中文说明
概要
这是 #1035 的第一个 PR,按 #1035 (comment) 里对齐的边界实现面向用户的展示信息。首页精选会另开 PR
shortDescription、overview、resetPresentation),或 CLI 发布时读取SKILL.md的metadata.short-description、metadata.overview。网页填写优先,上传包和SKILL.md原文不改displayNameOverride一样存在版本快照里,不新增数据库迁移description,详细描述回退到 README → SKILL.mdpresentationInheritedFrom,结果固定在这次提交。默认状态存为空,后续版本读新包自己的默认内容,不会把旧默认文本当成自定义复制过去description保留在search_text,原有检索不受影响;详细描述暂不进索引add-skill-presentation-fields,重新生成的 OpenAPI 类型,中英文翻译验证
make test-backend-app:1526 项里只剩 GitHub 同步相关的并发/集成测试不稳定(每次失败的用例不同;同一命令在未改动的 base326cbd62上也会失败,5 失败 10 错误)。其余全部通过,交给 CI 确认风险