Repository navigation
Retry stapling when Apple's ticket service drops the connection - #241
Merged
Merged
Conversation
Two releases in a row (v1.25.3, v1.25.4) failed after notarization succeeded, because stapler lost its connection to Apple's CloudKit ticket service (-1005, error 68). Staple and validate now retry up to four times with a growing delay, and the release workflow no longer runs a second, redundant validate after build-dmg.sh has done it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.25.3 and v1.25.4 release runs both failed after Apple had accepted the notarization, because
xcrun staplerlost its connection to Apple's CloudKit ticket service:Both needed a manual re-run of the job.
scripts/build-dmg.sh: astapler_with_retryhelper wraps all fourstapler staple/validatecalls (app and DMG), retrying up to 4 times with a 15/30/45 s delay, then failing loudly.release.yml: drops the extrastapler validateafterbuild-dmg.sh, which already validates the DMG. That duplicate is where v1.25.4 failed.Tested the helper with a stubbed
xcrun(succeeds on the 3rd attempt; fails after 4).bash -nand YAML parse pass. No VERSION bump: release tooling only, the app is unchanged.