Repository navigation
Spanish - #243
Open
helloworldxdwastaken wants to merge 2 commits into
Open
Spanish#243helloworldxdwastaken wants to merge 2 commits into
helloworldxdwastaken wants to merge 2 commits into
Conversation
iliyami
requested changes
Oct 19, 2026
iliyami
left a comment
Owner
There was a problem hiding this comment.
Thank you @helloworldxdwastaken, and thank you for being upfront that this is machine-assisted. I reviewed it carefully:
- Code and safety: all good. Only the language plumbing changes (enum case, locale mapping, dictionary, kept
.lprojfolders, Info.plist), existing translations are untouched, and the new strings contain no URLs, invisible characters, em dashes, duplicate keys, or lost placeholders. The tests mirror the Italian ones and add the language to every per-module loop. Merged with current main, the full suite passes locally (1,056 tests, 0 failures). Nice touch translating the three strings no other language had yet ("Scanning disk…", "No items found", "System"). - Translation: good base, needs a fix pass. I had every entry reviewed against the English meaning and Apple's own terminology. Most of it is accurate, but there are machine-translation errors, a few of which change what a safety message says. Those must be fixed before merge.
Spanish: required fixes
Line numbers refer to Sources/MacCleanKit/Localization.swift in this PR.
Critical
- 468 (Restore description): "Vuelve a tener una limpieza completa con un solo clic…" reads as "run a full cleanup again", the opposite of Restore. Suggest: "Restaura una limpieza completa con un solo clic. Se omiten los elementos que ya se vaciaron de la Papelera o cuyo lugar original ocupa ahora un archivo nuevo."
Major
- Broken tú/usted replacement typos: 261 "necesites" sentence, 278 "no usass", 282 "necesitess", 473 "usasn", 701 "no usass". For example 278: "Traducciones de idiomas que no usas. Eliminarlas modifica el paquete de la aplicación; reinstálala para recuperarlas." and 282: "Los elementos seleccionados están en la Papelera: recupera lo que necesites. Para borrarlos definitivamente, abre Papeleras y vacíala."
- Register: about 21 strings still use usted while the rest use tú (315, 334, 384, 406, 459, 467, 502, 540, 560, 562, 567, 669, 719, 738, 780, 791), and 629, 675, 680, 741 switch mid-sentence. Please use tú throughout.
- Full Disk Access: Apple's Spanish term is "Acceso total al disco" (379, 810 use "Acceso completo al disco").
- Wrong word sense: 396 "Admite archivos…" (reads "supports files") → "Archivos de soporte de aplicaciones que has eliminado."; 300 and 578 "artículo" → "elemento"; 331 and 729 "camino" → "ruta"; 384 "número de GitHub" → "issue de GitHub"; 336 "Seguro de eliminar" → "Se puede eliminar sin riesgo".
- 419 "Próximo lanzamiento regenerado." is broken → "Archivos temporales de las aplicaciones. Se regeneran la próxima vez que se abren."
- Module names that drop "junk" (they now sound like they clean all files): 232 Xcode junk, 815 Project Junk, 712 System Junk (e.g. "Basura de Xcode", "Basura de proyectos", "Basura del sistema"), and 722 should use the translated module name.
- 680 "Haz clic en Smart Scan" names a button that is "Análisis inteligente" in Spanish.
- 634 destructive button "Eliminación permanente" is a noun → "Eliminar permanentemente".
- 227 "Gestiónalas en los ajustes de Safari."; 276 "Las instantáneas locales de Time Machine…".
Worth fixing (minor): "este Mac" vs "esta Mac" is mixed (Apple uses masculine); scan vocabulary is split between "escanear" and "analizar" (pick one); "Sólo" → "Solo"; no capital after a semicolon (261, 280, 722); Docker is not a simulator (217, 764); 405 "Restaurados: %ld".
Housekeeping (applies to all five of your PRs)
- All five PRs set VERSION to 1.25.5, and main is moving to 1.25.7 (#249, #250, #251). They'll be merged one at a time, so please rebase each onto main right before it's ready and bump to the next free patch version then (
bash scripts/check-version-sync.sh). - #250 replaces the Language Cleanup caption key in Settings (
英文、基础资源、中文、俄文和德文会始终保留…becomesBase 资源、Mac Sai 的界面语言以及你的 Mac 在“语言与地区”中设置的语言会始终保留…), and #251 adds two launch-at-login error sentences with a{message}placeholder. After rebasing, please translate those and drop the old caption entry plus the开启/关闭entries, which are no longer used. - Next time, please comment on #12 to claim a language before starting, so two people don't translate the same one. And since these are machine-assisted, a note on #12 inviting a native speaker to proofread would be very welcome.
Once the fixes above are in, I'm happy to merge. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #12. Machine-assisted; native review needed.
616 static strings. Version, build and localization checks pass; interpolated strings keep their English fallback.