Repository navigation
feat: pass a confidential flag through execute, the tools and the CLI - #12
Draft
Jakub Hamadej (JakeHamix) wants to merge 1 commit into
Draft
Jakub Hamadej (JakeHamix) wants to merge 1 commit into
Jakub Hamadej (JakeHamix) wants to merge 1 commit into
Conversation
Make's Endpoint execution API accepts an optional `confidential` boolean (BAR-4271): like a scenario with "Data is confidential", the execution log then keeps no input, output or error data, only metadata. The flag is now an `EndpointOptions` field (both transports spread the options into the body, so `execute()` sends it as its own field, never inside `input`), a reserved argument on every endpoint tool and on `endpoints_execute`, and therefore a `--confidential` flag on every CLI call. The generated per-app methods type it once the generator's template carries it; until then the generic `execute()` is the typed way to pass it.
Collaborator
Author
|
Companion draft PRs for BAR-4271 (deploy order top to bottom):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Make's Endpoint execution API accepts an optional
confidentialboolean (BAR-4271): like a scenario with "Data is confidential", the execution log then keeps no input, output or error data, only metadata. The SDK, the tools and the CLI had no way to pass it.What
EndpointOptions.confidential?: booleaninshared.ts(both transports already spread the options into the body, soexecute()sends it as its own field, never insideinput).tools.ts:confidentialis a reserved argument and aCONFIDENTIAL_SCHEMAproperty on every endpoint tool and onendpoints_execute;_callEndpointvalidates it as a boolean.--confidentialon every call, derived from the schemas as usual;SKILL.md,snippet.md/README and the root help'sStart heremention it.execute()is the typed way to pass it.Order
Public runtime first (this PR), then the mono generator, then the nightly sync.
shared.tsstays byte-identical to mono's copy. web-api must accept the field before anyone sends it (imt-web-api draft PR linked in the first comment).Verification
npm run type-check,vitest(502 tests),npm run build,npm run check:package— green.