Repository navigation
Update Isaac Lab Arena submodule to Lab EA2 - #43
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR updates the IsaacLab-Arena submodule, upgrades the Isaac Sim Docker image to ChangesEnvironment and runtime updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
conda_installer.sh (1)
44-59: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
activate_envdoesn't verify the activated env is actually${ENV_NAME}.The check only verifies a python binary exists at
${CONDA_PREFIX}/bin/python; it doesn't verifyconda activate "${ENV_NAME}"actually succeeded and switched into the intended env. If activation silently fails (e.g. env not found, and the script lacksset -e),CONDA_PREFIXmay still point at a previously active env (e.g.base), which will also have a valid python binary, so the check passes and subsequentuv pip installcalls proceed into the wrong environment.🔧 Proposed fix to validate the activated environment
conda activate "${ENV_NAME}" + if [[ "${CONDA_DEFAULT_ENV}" != "${ENV_NAME}" ]]; then + echo "error: failed to activate conda env '${ENV_NAME}' (currently in '${CONDA_DEFAULT_ENV}')." >&2 + exit 1 + fi + if [[ ! -x "${CONDA_PREFIX}/bin/python" ]]; then echo "error: Python was not found in the '${ENV_NAME}' conda env." >&2 exit 1 fi🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@conda_installer.sh` around lines 44 - 59, Update activate_env to verify that conda activate "${ENV_NAME}" succeeds and that the resulting active environment matches ENV_NAME before validating its Python binary or exporting UV_PYTHON. If activation fails or CONDA_PREFIX does not identify ENV_NAME, emit an error and exit instead of continuing with a previously active environment.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@conda_installer.sh`:
- Around line 99-103: Replace the global --index-strategy unsafe-best-match
option in the Isaac Sim installation command with narrowly scoped per-package
index configuration for isaacsim and any required split extras. Keep the NVIDIA
extra index available while ensuring unrelated dependencies resolve from the
intended default index without cross-index best-match selection.
---
Outside diff comments:
In `@conda_installer.sh`:
- Around line 44-59: Update activate_env to verify that conda activate
"${ENV_NAME}" succeeds and that the resulting active environment matches
ENV_NAME before validating its Python binary or exporting UV_PYTHON. If
activation fails or CONDA_PREFIX does not identify ENV_NAME, emit an error and
exit instead of continuing with a previously active environment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 159d1365-81df-43c6-9ea5-06a45becbbef
📒 Files selected for processing (2)
AGENTS.mdconda_installer.sh
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@AGENTS.md`:
- Around line 7-8: Clarify the container workflow in the repository
instructions: state that ./docker/run_docker.sh (including the -c variant) must
be run from the host to start or create the isaac_autodata container, while all
subsequent repository scripts and commands must run inside that container.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 6302a70c-ead5-4402-b4f8-a78acbf70d6c
📒 Files selected for processing (1)
AGENTS.md
Summary
Update Arena submodule to version that includes Isaac Lab EA2: isaac-sim/IsaacLab-Arena@8b82dca
Changes:
Summary by CodeRabbit
Chores
Documentation
isaac_autodataDocker container.Bug Fixes