Repository navigation
Conversation
In the backend, ensure every HTTP response carries an x-request-id header: reuse the incoming x-request-id when the client sends one, otherwise generate a UUID. Add a unit test that asserts both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request
Changelog for users
x-request-idheader.x-request-id, the response echoes it back unchanged.x-request-id, the backend generates a new UUID v4 for that response.Changelog for maintainers
withRequestIdmiddleware exportingREQUEST_ID_HEADER(x-request-id); it wraps the proxy chain outermost, so it stamps responses produced by downstream wrappers as well, including early returns such as blocked clients (426) and 404s.x-request-idwhen present, otherwise generates one viacrypto.randomUUID().apps/web/src/proxy.tskeepswithRequestIdoutermost so no early-return path bypasses the header.E2E proof
Follow-ups (not changed here)