Skip to content

Follow up fixes for 1145 - #1165

Merged
pljones merged 4 commits into
jamulussoftware:next-releasefrom
pljones:followup-fixes-for-1145
Sep 13, 2026
Merged

Follow up fixes for 1145#1165
pljones merged 4 commits into
jamulussoftware:next-releasefrom
pljones:followup-fixes-for-1145

Conversation

@pljones

@pljones pljones commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Short description of changes

Fixes final review comments on #1145

  • Removes dangling .po files
  • Corrects remaining reference to server command line options in a blog post
  • Corrects headings to use sentence case

Context: Fixes an issue? Related issues

N/A - post merge follow up work

Status of this Pull Request

Verified locally and published to https://jamuluswebsite.drealm.info/

What is missing until this pull request can be merged?

Needs review.

Does this need translation?

Shouldn't introduce additional work unless anyone's already done the upper case versions.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I'm sure that this Pull Request goes to the correct branch

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Advanced

Run ID: 943712c5-e746-4a6a-bc87-21c028146318

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: QUIET

Plan: Advanced

Run ID: 745a5213-4fb6-4acb-b914-f3ef5abd23a9

📥 Commits

Reviewing files that changed from the base of the PR and between 4145baf and e00f510.

📒 Files selected for processing (18)
  • _posts/2020-03-28-Server-Rpi.md
  • _translator-files/po/de/Command-Line-Options.po
  • _translator-files/po/es/Command-Line-Options.po
  • _translator-files/po/fr/Command-Line-Options.po
  • _translator-files/po/it/Command-Line-Options.po
  • _translator-files/po/ko-KR/Command-Line-Options.po
  • _translator-files/po/nb-NO/Command-Line-Options.po
  • _translator-files/po/nl/Command-Line-Options.po
  • _translator-files/po/pt-BR/Command-Line-Options.po
  • _translator-files/po/pt-PT/Command-Line-Options.po
  • _translator-files/po/ru/Command-Line-Options.po
  • _translator-files/po/sv-SE/Command-Line-Options.po
  • _translator-files/po/th/Command-Line-Options.po
  • _translator-files/po/zh-CN/Command-Line-Options.po
  • wiki/en/Include-Server-Commands.md
  • wiki/en/Running-a-Server.md
  • wiki/en/Server-Troubleshooting.md
  • wiki/en/Software-Manual.md
💤 Files with no reviewable changes (13)
  • _translator-files/po/nb-NO/Command-Line-Options.po
  • _translator-files/po/pt-BR/Command-Line-Options.po
  • _translator-files/po/th/Command-Line-Options.po
  • _translator-files/po/pt-PT/Command-Line-Options.po
  • _translator-files/po/de/Command-Line-Options.po
  • _translator-files/po/es/Command-Line-Options.po
  • _translator-files/po/ru/Command-Line-Options.po
  • _translator-files/po/it/Command-Line-Options.po
  • _translator-files/po/zh-CN/Command-Line-Options.po
  • _translator-files/po/sv-SE/Command-Line-Options.po
  • _translator-files/po/nl/Command-Line-Options.po
  • _translator-files/po/ko-KR/Command-Line-Options.po
  • _translator-files/po/fr/Command-Line-Options.po

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🔇 Additional comments (5)
wiki/en/Running-a-Server.md (1)

164-164: LGTM!

wiki/en/Software-Manual.md (1)

380-380: LGTM!

wiki/en/Server-Troubleshooting.md (1)

26-26: LGTM!

_posts/2020-03-28-Server-Rpi.md (1)

40-40: LGTM!

wiki/en/Include-Server-Commands.md (1)

20-20: LGTM!


📝 Walkthrough

Walkthrough

The documentation now uses consistent sentence-case command-line-options headings and references the server options section directly. A server-option typo was corrected. Twelve localized command-line-options translation catalogs were deleted.

Changes

Command-line options documentation

Layer / File(s) Summary
Align English headings and references
wiki/en/..., _posts/2020-03-28-Server-Rpi.md
Command-line-options headings and link text now use sentence case. The Raspberry Pi guide links directly to the server options section. The --startminimized description typo was corrected.
Remove obsolete translation catalogs
_translator-files/po/*/Command-Line-Options.po
German, Spanish, Italian, Korean, Norwegian Bokmål, Dutch, Portuguese, Russian, Swedish, Thai, and Simplified Chinese catalogs were deleted.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to e00f5

The PR contains documentation-only corrections with no remaining merge-blocking risk.

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Style And Kiss Check ⚠️ Warning The PR introduces two documentation style violations. wiki/en/Include-Server-Commands.md:20 uses “minimized”, but the project style guide requires British English, including “minimise”. `_posts/2020… Change the table text to start minimised. Change the blog-post link label to Server command line options so it matches the target heading and the sentence-case style. Then recheck the Markdown diff.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately identifies this as follow-up work for PR #1145. It is concise and relevant, although it does not name the documentation and translation cleanup changes.
Description check ✅ Passed The description covers the required sections, summarizes the changes, states the context and status, identifies review as the remaining step, addresses translation impact, and completes the checklist.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Privacy And Security Check ✅ Passed PASS. The authoritative diff changes only five Markdown files and deletes thirteen PO translation catalogs. The additions are documentation links, heading case changes, and a spelling correction. No c…
Slop Check ✅ Passed PASS. The patch is focused and coherent. It contains three separate commits for catalog cleanup, link correction, and sentence-case edits. The deleted catalogs reference a source page that is already …
Full details: Style And Kiss Check

Explanation

The PR introduces two documentation style violations. wiki/en/Include-Server-Commands.md:20 uses “minimized”, but the project style guide requires British English, including “minimise”. _posts/2020-03-28-Server-Rpi.md:40 uses “Server Command Line Options”, while the linked heading is now “Server command line options” and the style guide requires sentence case and lower-case generic nouns. The main CONTRIBUTING.md directs contributors to this style guide. git diff --check passes, and the deleted PO files match the repository instruction for removing a source page.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pljones

pljones commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

I'm pretty sure this changes (neither this PR, nor #1145) introduce "minimized". I'll check...

Oh look

Jamulus --help
...
  -z, --startminimized    start minimized

I'll stick with reporting what is actually used.

@ann0see ann0see left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise ok

Comment thread wiki/en/Server-Troubleshooting.md
@pljones
pljones force-pushed the followup-fixes-for-1145 branch from e00f510 to b286801 Compare September 13, 2026 12:40
@pljones
pljones merged commit bf0842f into jamulussoftware:next-release Sep 13, 2026
2 checks passed
@pljones
pljones deleted the followup-fixes-for-1145 branch September 13, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants