[heide-oficial]

Fixes for the paint and texture tools, found while auditing 1.9.3 with Blockbench 5.2.1 on Windows. One commit per issue:

• texture_selection: it called rectangle-selection methods that no longer exist in Blockbench 5.2, and left an Undo edit open, so the next paint call failed. This is also where tsc reports 16 errors on main. Selections are now read and written per pixel through IntMatrix, inputs are checked before the edit opens, and feather_selection is refused with an explanation.
• apply_texture marked the texture modified: it called updateChangesAfterEdit(), which re-encodes the bitmap, turns a file texture into an internal one and flags it unsaved. A Ctrl+S then rewrote the PNG although only face assignments changed. The call is removed.
• apply_texture with applyTo: "none": it mapped to Texture.apply(false), which textures the faces selected in the UV editor and all six faces of box-UV cubes. none now changes nothing, and the option's description says what each mode does.
• paint_fill_tool seeds:
  • In face and element modes, a seed that hit no face made Blockbench fill the whole texture.
  • Seeds outside the texture, or outside the active layer of a layered texture, made color fills match every transparent pixel.
  • Seeded fills now need a pixel inside the texture and the active layer. Face and element fills also need a face, found the way Painter.useFilltool finds it (UVEditor.findFaceAtUV). All checks run before anything is activated.
• paint_with_brush:
  • It stamped pixels itself, so blend mode, pixel-perfect drawing, lock alpha, mirror painting and the current brush were ignored, and omitted settings reset the brush to a 1 px black square.
  • It now paints one native brush_tool stroke like the other paint tools, and writes only the given settings to the brush.
  • Hex colours are normalized, so #F00 paints #FF0000 instead of #F00000. Other colour strings are accepted as before.
  • On hosts older than 5.2, disconnected points are painted as separate strokes.
• create_texture: it required layer_name with fill_color but never used it. It is now optional and documented as deprecated.
• color_picker_tool: it was annotated read-only, although it changes the active colours and can switch the tool. It is now annotated as a non-destructive state change.

Behaviour changes to be aware of:

• apply_texture none is a no-op.
• paint_fill_tool rejects seeds outside the texture or the active layer, and face/element seeds that hit no face.
• In paint_with_brush, omitted settings keep the current brush.
• Clients that auto-approve read-only tools will now ask before color_picker_tool.

Not included: with Blockbench's colour-picker tool switch on, picking a transparent pixel sets no colour, and color_picker_tool then reports the previous colour.

Testing:

• bun test: 1,208 pass, 0 fail (main: 1,184). bunx tsc --noEmit: only the 3 errors main already has in lib/factories.ts; the 16 in selection-tools.ts are gone. bun run build and bun run docs:build pass.
• Live, with all the related PRs loaded together in Blockbench 5.2.1 on Windows 11, each of these failed in the audit of 1.9.3 and passes now:
  • Painting after texture_selection.
  • applyTo: "none" on a box-UV cube.
  • #F00 painting #FF0000.
  • A face fill seeded outside the texture.
• Upstream's test:actions:live (61 checks) and test:pbr:live (75 checks) pass against the same build. The action-wrappers and mcp-identity smoke scripts are updated for the new behaviour.

Related PRs from the same audit: #70 (HTTP server, settings and file inputs), #71 (views and captures), #72 (modeling tools), #73 (animation, GeckoLib and display), #75 (headless server), #69 (loopback bind). All of them merge together without conflicts (checked).

🤖 Generated with Claude Code

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: jasonjgardner/blockbench-mcp-plugin/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 04b521f9-0c4f-41c9-b5b0-cb541639ae0d

📥 Commits

Reviewing files that changed from the base of the PR and between 6295e20 and 4dd816e.

📒 Files selected for processing (18)

• lib/factories.test.ts
• server/tools/paint/brush-stroke.ts
• server/tools/paint/brush-tools.ts
• server/tools/paint/docs.ts
• server/tools/paint/layer-tools.test.ts
• server/tools/paint/native-painter.ts
• server/tools/paint/paint-math.test.ts
• server/tools/paint/paint-math.ts
• server/tools/paint/schemas.ts
• server/tools/paint/selection-tools.ts
• server/tools/paint/stroke-tools.ts
• server/tools/texture.ts
• server/tools/texture/apply-texture.ts
• tests/apply-texture.test.ts
• tests/live/action-wrappers-smoke.ts
• tests/live/mcp-identity-smoke.ts
• tests/paint-wrappers.test.ts
• tests/texture-undo.test.ts

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}