Repository navigation
Add .clang-tidy and other quality improvements - #75
Merged
Merged
Conversation
Add explicit static_cast<uint64_t>() to multiplication operations where the result is assigned to a 64-bit type but operands are 32-bit, preventing potential overflow before widening. Fixes clang-tidy bugprone-implicit-widening-of-multiplication-result 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Mark member functions as const where they only read member variables without modifying them, improving const correctness throughout the codebase. Fixes clang-tidy readability-make-member-function-const 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use modern C++ nullptr instead of NULL or literal 0 when comparing or assigning pointer values. Fixes clang-tidy modernize-use-nullptr 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Functions defined in class bodies are implicitly inline, so the explicit inline specifier is redundant. Fixes clang-tidy readability-redundant-inline-specifier 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
In C++, empty parentheses already indicate no parameters, making the explicit (void) parameter list redundant. Fixes clang-tidy modernize-redundant-void-arg 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Top-level const on return types is ignored for non-reference/pointer types and reduces readability without improving const correctness. Fixes clang-tidy readability-const-return-type 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Make auto declarations more explicit by adding * or & qualifiers when the deduced type is a pointer or reference, improving code readability. Fixes clang-tidy readability-qualified-auto 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ensure parameter names match between function declarations in headers and their definitions in source files. Fixes clang-tidy readability-inconsistent-declaration-parameter-name 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
pthread_t is an integer type (unsigned long) on Linux, not a pointer, so it cannot be initialized with nullptr. Use 0 instead. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.