Skip to content

perf(vcs): read the reviewed commit from the checkout - #171

Merged
jdziat merged 6 commits into
mainfrom
perf/design-sources-from-checkout
Oct 7, 2026
Merged

jdziat merged 6 commits into
mainfrom
perf/design-sources-from-checkout

Conversation

@jdziat

@jdziat jdziat commented Oct 5, 2026 •

Copy link
Copy Markdown
Owner

The design pass in #169 overlaps its forge requests, but a one-file review still makes about 490 of them: one per file and directory, plus two more per file because a read that named no revision fetched the pull request and its head commit first. The Action already has the full history on disk.

This reads the reviewed commit from the checkout when it holds that commit. File reads use the commit's objects, never the working tree, so an edited or untracked file cannot change what is reviewed. Directory listings come from one git ls-tree per commit, and the head commit is asked for once per pull request. A checkout that lacks the commit, or a path that is not a regular file there, goes to the API as before.

In two CI runs the design source read took 290ms and 285ms over the same 93 directories and 398 files, against 16.6s before this change and 1m6s before #169. design assembled fell from 17.1s to 0.9s. Two runs are a small sample; docs/findings.md says so.

Tests pin requests per read, working-tree isolation, symlink and submodule listing, the missing-commit fallback, and retry after a transient git failure. Each fails when its guard is removed.

Fixes #167

@open-nitpick open-nitpick Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic analyzers: 1 ran

Analyzer configuration is policy, and a change may not supply the policy it is
reviewed under, so no analyzer read this repository's own lint settings.

  • golangci-lint — ran: isolated: open-nitpick's own analyzer config
Read 3 changed files. 435 files had nothing to review. 2 findings: 1 warning, 1 info. Analyzers: golangci-lint.

Findings: 1 warning, 1 info

Files not reviewed
  • declaration:internal/vcs/github.go:13: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:15: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:16: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:19: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:22: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github_checkout.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout.go
  • declaration:internal/vcs/github_checkout_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:cmd/nitpick/actions.go:9: complete design task exceeds review.max_files_per_request: cmd/nitpick/actions.go
  • declaration:cmd/nitpick/appauth.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth.go
  • declaration:cmd/nitpick/appauth_test.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:11: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/commits.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/commits.go
  • declaration:cmd/nitpick/commits_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/commits_test.go
  • declaration:cmd/nitpick/commits_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/commits_test.go
  • declaration:cmd/nitpick/commits_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/commits_test.go
  • declaration:cmd/nitpick/engineering.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering.go
  • declaration:cmd/nitpick/engineering.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering.go
  • declaration:cmd/nitpick/engineering_model.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_model.go
  • declaration:cmd/nitpick/engineering_review.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_snapshot.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_snapshot.go
  • declaration:cmd/nitpick/engineering_test.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:15: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:16: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:18: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:20: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:23: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:24: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:29: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:39: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:42: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/enginewiring_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/enginewiring_test.go
  • declaration:cmd/nitpick/enginewiring_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/enginewiring_test.go
  • declaration:cmd/nitpick/fastreview.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview.go
  • declaration:cmd/nitpick/fastreview.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview.go
  • declaration:cmd/nitpick/fastreview.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview.go
  • declaration:cmd/nitpick/fastreview_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview_test.go
  • declaration:cmd/nitpick/fix.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fullreview.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/fullreview.go
  • declaration:cmd/nitpick/improve.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:12: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve_test.go
  • declaration:cmd/nitpick/init.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/init.go
  • declaration:cmd/nitpick/init.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/init.go
  • declaration:cmd/nitpick/init.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/init.go
  • declaration:cmd/nitpick/init.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/init.go
  • declaration:cmd/nitpick/init_test.go:15: complete design task exceeds review.max_files_per_request: cmd/nitpick/init_test.go
  • declaration:cmd/nitpick/knowledge_wiring_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/knowledge_wiring_test.go
  • declaration:cmd/nitpick/knowledge_wiring_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/knowledge_wiring_test.go
  • declaration:cmd/nitpick/knowledge_wiring_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/knowledge_wiring_test.go
  • declaration:cmd/nitpick/main.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/main.go
  • declaration:cmd/nitpick/mcp.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp.go
  • declaration:cmd/nitpick/mcp.go:19: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp.go
  • declaration:cmd/nitpick/mcp.go:21: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp.go
  • declaration:cmd/nitpick/mcp.go:27: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp.go
  • declaration:cmd/nitpick/mcp_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp_test.go
  • declaration:cmd/nitpick/mcp_test.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp_test.go
  • declaration:cmd/nitpick/mcp_test.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp_test.go
  • declaration:cmd/nitpick/mcp_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp_test.go
  • declaration:cmd/nitpick/repo_standards.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/repo_standards.go
  • declaration:cmd/nitpick/repo_standards.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/repo_standards.go
  • declaration:cmd/nitpick/repo_standards.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/repo_standards.go
  • declaration:cmd/nitpick/respond.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond.go
  • declaration:cmd/nitpick/respond.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond.go
  • declaration:cmd/nitpick/respond_policy_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_policy_test.go
  • declaration:cmd/nitpick/respond_policy_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_policy_test.go
  • declaration:cmd/nitpick/respond_policy_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_policy_test.go
  • declaration:cmd/nitpick/respond_policy_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_policy_test.go
  • declaration:cmd/nitpick/respond_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_test.go
  • declaration:cmd/nitpick/review.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:15: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:16: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:17: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:18: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:19: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:20: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:21: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:23: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:29: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:9: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/security.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/security.go
  • declaration:cmd/nitpick/security.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/security.go
  • declaration:cmd/nitpick/security.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/security.go
  • declaration:cmd/nitpick/security_test.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/security_test.go
  • declaration:cmd/nitpick/security_test.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/security_test.go
  • declaration:cmd/nitpick/slop.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/slop.go
  • declaration:cmd/nitpick/slop.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/slop.go
  • declaration:cmd/nitpick/slop.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/slop.go
  • declaration:cmd/nitpick/standards.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:cmd/nitpick/standards.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:cmd/nitpick/standards.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:cmd/nitpick/standards_test.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards_test.go
  • declaration:cmd/nitpick/standards_test.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards_test.go
  • declaration:cmd/nitpick/standards_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards_test.go
  • declaration:cmd/nitpick/standards_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards_test.go
  • declaration:internal/bundle/related.go:19: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/bundle/related.go:29: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/bundle/related.go:47: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/bundle/related_test.go:11: complete design task exceeds review.max_files_per_request: internal/bundle/related_test.go
  • declaration:internal/bundle/related_test.go:13: complete design task exceeds review.max_files_per_request: internal/bundle/related_test.go
  • declaration:internal/bundle/related_test.go:8: complete design task exceeds review.max_files_per_request: internal/bundle/related_test.go
  • declaration:internal/bundle/related_test.go:9: complete design task exceeds review.max_files_per_request: internal/bundle/related_test.go
  • declaration:internal/config/basepolicy.go:2: complete design task exceeds review.max_files_per_request: internal/config/basepolicy.go
  • declaration:internal/config/basepolicy.go:3: complete design task exceeds review.max_files_per_request: internal/config/basepolicy.go
  • declaration:internal/config/policy_test.go:30: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/policy_test.go:31: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/policy_test.go:32: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/policy_test.go:33: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/policy_test.go:34: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/practices.go:7: complete design task exceeds review.max_files_per_request: internal/config/practices.go
  • declaration:internal/config/practices.go:8: complete design task exceeds review.max_files_per_request: internal/config/practices.go
  • declaration:internal/config/practices_test.go:2: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:3: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:4: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:5: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:6: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:7: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:8: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:9: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/evals/callers_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/callers_test.go
  • declaration:internal/evals/callers_test.go:2: complete design task exceeds review.max_files_per_request: internal/evals/callers_test.go
  • declaration:internal/evals/dump.go:11: complete design task exceeds review.max_files_per_request: internal/evals/dump.go
  • declaration:internal/evals/dump.go:13: complete design task exceeds review.max_files_per_request: internal/evals/dump.go
  • declaration:internal/evals/eval_test.go:3: complete design task exceeds review.max_files_per_request: internal/evals/eval_test.go
  • declaration:internal/evals/fixtures.go:7: complete design task exceeds review.max_files_per_request: internal/evals/fixtures.go
  • declaration:internal/evals/fixtures_dedup_test.go:12: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:14: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:15: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:16: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:17: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:18: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:19: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fullreview_eval_test.go:4: complete design task exceeds review.max_files_per_request: internal/evals/fullreview_eval_test.go
  • declaration:internal/evals/groundtruth_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:12: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:17: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:2: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:22: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:23: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:24: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:25: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:27: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:3: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:30: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:35: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:42: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:43: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:48: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:49: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:51: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:54: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:59: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:60: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:61: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:62: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:64: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:66: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:67: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:68: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:69: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:70: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:71: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:72: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:73: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/harness.go:11: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:12: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:13: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:14: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:15: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:27: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:30: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:5: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:7: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/infocorpus_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/infocorpus_test.go
  • declaration:internal/evals/infocorpus_test.go:2: complete design task exceeds review.max_files_per_request: internal/evals/infocorpus_test.go
  • declaration:internal/evals/multifile_eval_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/multifile_eval_test.go
  • declaration:internal/evals/multifile_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/multifile_test.go
  • declaration:internal/evals/multifile_test.go:3: complete design task exceeds review.max_files_per_request: internal/evals/multifile_test.go
  • declaration:internal/evals/rejudge.go:22: complete design task exceeds review.max_files_per_request: internal/evals/rejudge.go
  • declaration:internal/evals/rejudge_test.go:23: complete design task exceeds review.max_files_per_request: internal/evals/rejudge_test.go
  • declaration:internal/evals/score.go:59: complete design task exceeds review.max_files_per_request: internal/evals/score.go
  • declaration:internal/evals/security_eval_test.go:7: complete design task exceeds review.max_files_per_request: internal/evals/security_eval_test.go
  • declaration:internal/evals/tune_test.go:12: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:13: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:14: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:6: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:7: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:9: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/linters/gate_test.go:18: complete design task exceeds review.max_files_per_request: internal/linters/gate_test.go
  • declaration:internal/review/approve_residual_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:13: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:3: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:4: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:8: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/approve_test.go
  • declaration:internal/review/approve_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/approve_test.go
  • declaration:internal/review/budget_apply.go:1: complete design task exceeds review.max_files_per_request: internal/review/budget_apply.go
  • declaration:internal/review/budget_apply.go:3: complete design task exceeds review.max_files_per_request: internal/review/budget_apply.go
  • declaration:internal/review/classfilter_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/classfilter_test.go
  • declaration:internal/review/classfilter_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/classfilter_test.go
  • declaration:internal/review/design_evidence_test.go:3: complete design task exceeds review.max_files_per_request: internal/review/design_evidence_test.go
  • declaration:internal/review/design_plan.go:2: complete design task exceeds review.max_files_per_request: internal/review/design_plan.go
  • declaration:internal/review/design_plan_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:16: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:17: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:4: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/discardnotice_test.go:18: complete design task exceeds review.max_files_per_request: internal/review/discardnotice_test.go
  • declaration:internal/review/discardnotice_test.go:22: complete design task exceeds review.max_files_per_request: internal/review/discardnotice_test.go
  • declaration:internal/review/engine.go:26: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:34: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:35: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:36: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:37: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:58: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:68: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:80: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine_test.go:17: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:18: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:21: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:22: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:23: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:24: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:26: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:27: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:28: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:29: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:30: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:37: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:38: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:39: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:40: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/fast_review_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:16: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:8: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/gitpolicy_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/gitpolicy_test.go
  • declaration:internal/review/gitpolicy_test.go:8: complete design task exceeds review.max_files_per_request: internal/review/gitpolicy_test.go
  • declaration:internal/review/incomplete_test.go:14: complete design task exceeds review.max_files_per_request: internal/review/incomplete_test.go
  • declaration:internal/review/incomplete_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/incomplete_test.go
  • declaration:internal/review/incomplete_test.go:8: complete design task exceeds review.max_files_per_request: internal/review/incomplete_test.go
  • declaration:internal/review/incremental_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:13: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:14: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:16: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:17: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:18: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:21: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:22: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:23: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/integrity_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:6: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/noclaims_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/noclaims_test.go
  • declaration:internal/review/noclaims_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/noclaims_test.go
  • declaration:internal/review/paths_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/paths_test.go
  • declaration:internal/review/paths_test.go:3: complete design task exceeds review.max_files_per_request: internal/review/paths_test.go
  • declaration:internal/review/policy.go:4: complete design task exceeds review.max_files_per_request: internal/review/policy.go
  • declaration:internal/review/policy_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:13: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:14: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:16: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:17: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:18: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:19: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:20: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:21: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:27: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:28: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:29: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:32: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:33: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/priorspend_test.go:4: complete design task exceeds review.max_files_per_request: internal/review/priorspend_test.go
  • declaration:internal/review/priorspend_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/priorspend_test.go
  • declaration:internal/review/priorspend_test.go:6: complete design task exceeds review.max_files_per_request: internal/review/priorspend_test.go
  • declaration:internal/review/priorspend_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/priorspend_test.go
  • declaration:internal/review/progress_test.go:3: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:4: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:6: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/removals_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/removals_test.go
  • declaration:internal/review/removals_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/removals_test.go
  • declaration:internal/review/render.go:42: complete design task exceeds review.max_files_per_request: internal/review/render.go
  • declaration:internal/review/route.go:3: complete design task exceeds review.max_files_per_request: internal/review/route.go
  • declaration:internal/review/route_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/route_test.go
  • declaration:internal/review/triageskip_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/triageskip_test.go
  • declaration:internal/review/triageskip_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/triageskip_test.go
  • declaration:internal/review/validate_test.go:28: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:29: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:30: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:31: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:34: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:35: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:36: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:47: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/vcs/base_test.go:13: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:16: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/containment_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/github_test.go:11: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:12: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:13: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:19: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:20: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:21: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:22: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:23: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:27: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:28: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/incremental_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/integrity_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:10: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/local.go:10: complete design task exceeds review.max_files_per_request: internal/vcs/local.go
  • declaration:internal/vcs/local_test.go:10: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:11: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:12: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:13: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/progress_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/progress_test.go
  • declaration:internal/vcs/progress_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/progress_test.go
  • declaration:internal/vcs/progress_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/progress_test.go
  • declaration:internal/vcs/propose.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/propose.go
  • declaration:internal/vcs/propose_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/propose_test.go
  • declaration:internal/vcs/snapshot_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/tree.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/tree_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/tree_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/tree_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/tree_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/vcs.go:32: complete design task exceeds review.max_files_per_request: internal/vcs/vcs.go
  • file:cmd/nitpick/fastreview_live_test.go: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview_live_test.go
  • file:cmd/nitpick/queue_test.go: complete design task exceeds review.max_files_per_request: cmd/nitpick/queue_test.go
  • file:cmd/nitpick/slop_test.go: complete design task exceeds review.max_files_per_request: cmd/nitpick/slop_test.go
  • file:internal/evals/bigpr_eval_test.go: complete design task exceeds review.max_files_per_request: internal/evals/bigpr_eval_test.go
  • file:internal/evals/harness_pin_test.go: complete design task exceeds review.max_files_per_request: internal/evals/harness_pin_test.go
  • file:internal/evals/probe_eval_test.go: complete design task exceeds review.max_files_per_request: internal/evals/probe_eval_test.go
  • file:internal/review/design_budget.go: complete design task exceeds review.max_files_per_request: internal/review/design_budget.go
  • file:internal/review/practices_test.go: complete design task exceeds review.max_files_per_request: internal/review/practices_test.go
Reported by the reviewer, then withheld after a domain expert disagreed
  • internal/vcs/github_checkout.go:46 — Comment narrates the nil-vs-cancelled branch it sits on
    • triage (openrouter/qwen/qwen3.8-27b): assessment acknowledgement: The entry explicitly states it is not filing the caching concern and only critiques a comment that restates the code. It alleges no defect, risk, or missing coverage in the logic itself, only a stylistic preference for comment content.; original rationale: "Rule 1: the comment restates the condition on the next line, which already tests t!= nil against ctx.Err() == nil. A reader gets nothing from the prose that the code does not say; if a constraint motivated the asymmetry (why a cancelled run must not be cached), the comment should name it instead. Not filing the caching of a permanent nil for a commit the checkout lacks, since a checkout that gains commits mid-run is not a reachable state in the shown callers."
Engineering practices
Engineering practices (engineering):
  Policy: /home/runner/work/open-nitpick/open-nitpick/.nitpick.yaml
  slop-tells: completed; 3/3 targets examined, 0 findings
  conventions: completed; 3/3 targets examined, 0 findings
  design-boundaries: completed; 3/3 targets examined, 0 findings
  commits: completed; 1/1 targets examined, 0 findings
  slop: completed; 3/3 targets examined, 0 findings
    Withheld by triage (openrouter/qwen/qwen3.8-27b): Comment narrates the nil-vs-cancelled branch it sits on (assessment acknowledgement: The entry explicitly states it is not filing the caching concern and only critiques a comment that restates the code. It alleges no defect, risk, or missing coverage in the logic itself, only a stylistic preference for comment content.; original rationale: "Rule 1: the comment restates the condition on the next line, which already tests t!= nil against ctx.Err() == nil. A reader gets nothing from the prose that the code does not say; if a constraint motivated the asymmetry (why a cancelled run must not be cached), the comment should name it instead. Not filing the caching of a permanent nil for a commit the checkout lacks, since a checkout that gains commits mid-run is not a reachable state in the shown callers.")
  design: partial; 53/487 targets examined, 2 findings
    design tasks or required context did not complete
    Scope limit: Go import graph only; dynamic calls and external dependency implementations are not resolved
    Scope limit: package inventory is not proof of complete architecture review
    Scope limit: imports include all selected Go sources regardless of build constraints
    Scope limit: internal/knowledge/indexes excluded: matched an ignore pattern
    Scope limit: source inventory is bounded to 4096 paths and 32 MiB; only Go source has a dependency graph
    Scope limit: tasks assess named declaration and caller interactions; completion is not proof of every package-level design property
    Scope limit: change scope follows changed source declarations and two caller hops; manifest changes expand package scope; deeper callers remain outside the declared assessment
    Scope limit: coupling candidates match signature and body-token shape within a Go package; a shape match does not establish a shared policy
    Scope limit: context includes two implementation-call hops within the root package and its direct imports, state writers and package contracts; deeper bodies, transitive imports, dynamic dispatch and reflection are outside the task scope; method selection does not type-check receivers; aliases and unknown returned reference types are not tracked as state writes
    model.correctness [file; advisory] internal/vcs/github_checkout.go:85: ListDir omits symlinks where the API path includes them
      The comment claims the API leaves symlinks out of listings, but the GitHub contents API reports a symlink as a regular file entry, so the API path in ListDir includes it while the checkout path omits it. A directory containing a symlink therefore lists differently depending on whether the checkout holds the commit, and a reviewer walking the tree misses a file the API path would have surfaced. The assumption this rests on is that the REST contents API types symlinks as "file"; if that is wrong the comment is still unverified and the two paths should be shown equivalent by a test, which the new fallback test does not cover for ListDir.
    model.concurrency [file; advisory] internal/vcs/github_checkout.go:44: Index mutex is held across git subprocess execution
      index.mu is held across the cat-file and ls-tree subprocesses, and the PR text says #169 overlaps forge requests, so concurrent FileContent calls exist. While the first tree read runs, every other checkoutTree and headSHA caller blocks, including reads of commits the checkout could answer from cache or serve via the API in parallel; on a large repository one slow ls-tree stalls the whole read batch. Building the tree outside the lock and publishing it under the lock removes the stall at the cost of one duplicate read if two callers race on the same uncached commit.
  linters: completed; 3/3 targets examined, 0 findings
  security: not_selected; 0/0 targets examined, 0 findings
    no separate security assessment selected
Model usage is a provider-reported lower bound; SDK retries may add usage and no monetary tariff is assumed.
  openrouter/qwen/qwen3.8-27b: 2837 prompt tokens, 618 completion tokens; 1 calls with usage, 0 without usage, 0 failed
  openrouter/z-ai/glm-5.3-flash: 140786 prompt tokens, 4023 completion tokens; 3 calls with usage, 0 without usage, 0 failed
Design scope: Go import graph only; dynamic calls and external dependency implementations are not resolved
Design scope: package inventory is not proof of complete architecture review
Design scope: imports include all selected Go sources regardless of build constraints

Reviewed by open-nitpick.

Comment thread internal/vcs/github_checkout.go Outdated
Comment thread internal/vcs/github_checkout.go Outdated

@open-nitpick open-nitpick Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the 2 file(s) changed since the review at e3a607a, or still carrying findings from it.
1 other changed file(s) in this pull request were reviewed on an earlier
push and were not re-read; findings on them are in the earlier review.
2 earlier comment thread(s) were resolved: the lines they pointed at changed
and the finding did not recur.

Deterministic analyzers: 1 ran

Analyzer configuration is policy, and a change may not supply the policy it is
reviewed under, so no analyzer read this repository's own lint settings.

  • golangci-lint — ran: isolated: open-nitpick's own analyzer config
Read 2 changed files. 49 files had nothing to review. 4 findings: 1 warning, 2 info, 1 nit. Analyzers: golangci-lint.

Findings: 1 warning, 2 info, 1 nit

Files not reviewed
  • declaration:internal/vcs/github_checkout.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout.go
  • declaration:internal/vcs/github_checkout_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:cmd/nitpick/engineering_review.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/fix.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/improve.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/respond.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond.go
  • declaration:cmd/nitpick/review.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:18: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review_test.go:9: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/standards.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:internal/bundle/related.go:47: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/config/basepolicy.go:2: complete design task exceeds review.max_files_per_request: internal/config/basepolicy.go
  • declaration:internal/review/design_plan.go:2: complete design task exceeds review.max_files_per_request: internal/review/design_plan.go
  • declaration:internal/review/engine.go:26: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/integrity_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/policy_test.go:32: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/vcs/base_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/containment_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/github.go:16: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github_test.go:20: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:21: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:22: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:23: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/local_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/propose.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/propose.go
  • declaration:internal/vcs/snapshot_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/tree.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
Engineering practices
Engineering practices (engineering):
  Policy: /home/runner/work/open-nitpick/open-nitpick/.nitpick.yaml
  slop-tells: completed; 2/2 targets examined, 0 findings
  conventions: completed; 2/2 targets examined, 0 findings
  design-boundaries: completed; 2/2 targets examined, 0 findings
  commits: completed; 2/2 targets examined, 0 findings
  slop: completed; 2/2 targets examined, 1 findings
    model.slop [file; advisory] internal/vcs/github_checkout_test.go:134: Dangling comment fragment at end of test file
      Slop rule 3: the file ends with an orphaned comment fragment ('A checkout that lacks the commit, or a file the checkout cannot serve as') with no code after it, duplicating the comment above TestGitHubFallsBackToTheAPIWhenTheCheckoutCannotAnswer. Delete the line.
  design: partial; 11/59 targets examined, 3 findings
    design tasks or required context did not complete
    Scope limit: Go import graph only; dynamic calls and external dependency implementations are not resolved
    Scope limit: package inventory is not proof of complete architecture review
    Scope limit: imports include all selected Go sources regardless of build constraints
    Scope limit: internal/knowledge/indexes excluded: matched an ignore pattern
    Scope limit: source inventory is bounded to 4096 paths and 32 MiB; only Go source has a dependency graph
    Scope limit: tasks assess named declaration and caller interactions; completion is not proof of every package-level design property
    Scope limit: change scope follows changed source declarations and two caller hops; manifest changes expand package scope; deeper callers remain outside the declared assessment
    Scope limit: coupling candidates match signature and body-token shape within a Go package; a shape match does not establish a shared policy
    Scope limit: context includes two implementation-call hops within the root package and its direct imports, state writers and package contracts; deeper bodies, transitive imports, dynamic dispatch and reflection are outside the task scope; method selection does not type-check receivers; aliases and unknown returned reference types are not tracked as state writes
    model.correctness [file; advisory] internal/vcs/github_checkout.go:93: Submodule entries are dropped from the checkout tree listing
      The switch handles only tree and blob, so a submodule (mode 160000, type commit, emitted by ls-tree -r) is dropped from both dirs and modes. The API path lists a submodule in ListDir, so a repository with submodules gets different listings depending on whether the checkout or the API answers, the exact divergence the symlink case at line 95 was written to avoid. Add a commit case that appends the name to dirs[parent], mirroring the blob branch.
    model.correctness [file; advisory] internal/vcs/github_checkout.go:69: Checkout read failures are silently absorbed as API fallback
      Both git failures return nil with the error discarded, and the caller falls back to the API, so a wrong Checkout path or a broken clone is invisible: the run silently pays the per-file API cost this change exists to remove, with nothing in the log to say why. Logging the git error once per commit (or at least on the first failure) keeps the fallback while making the misconfiguration diagnosable; the tradeoff is log noise on repos that legitimately mix both paths.
    model.correctness [file; advisory] internal/vcs/github_checkout.go:119: Cached headSHA may pin the head-moved check to a stale commit
      Unresolved: The caching behavior is real, headSHA stores the first-seen head per ref and returns it for the rest of the run, but whether the publish path's ErrHeadMoved check reads the head through this helper is not shown in any supplied source, so the claimed consequence cannot be confirmed or refuted from the code in front of me.
      Once a head is cached, any later call to headSHA for the same ref returns the first-seen commit for the rest of the run. If the publish path detects ErrHeadMoved by re-reading the head through this helper (not shown in the supplied sources), it will now compare the review against its own cached value and never fire, so a push mid-run re-asserts whole files over the newer tree, the silent revert vcs.go's ErrHeadMoved doc describes. If publish fetches the head some other way, this is fine; the remedy is a fresh fetch at publish time, at the cost of one extra request per publish.
  linters: completed; 2/2 targets examined, 0 findings
  security: not_selected; 0/0 targets examined, 0 findings
    no separate security assessment selected
Model usage is a provider-reported lower bound; SDK retries may add usage and no monetary tariff is assumed.
  openrouter/qwen/qwen3.8-27b: 2252 prompt tokens, 767 completion tokens; 1 calls with usage, 0 without usage, 0 failed
  openrouter/z-ai/glm-5.3-flash: 82521 prompt tokens, 5324 completion tokens; 5 calls with usage, 0 without usage, 0 failed
Design scope: Go import graph only; dynamic calls and external dependency implementations are not resolved
Design scope: package inventory is not proof of complete architecture review
Design scope: imports include all selected Go sources regardless of build constraints

Reviewed by open-nitpick.

Comment thread internal/vcs/github_checkout.go
Comment thread internal/vcs/github_checkout.go
Comment thread internal/vcs/github_checkout.go
Comment thread internal/vcs/github_checkout_test.go Outdated

@open-nitpick open-nitpick Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the 2 file(s) changed since the review at 1b8ee7c, or still carrying findings from it.
1 other changed file(s) in this pull request were reviewed on an earlier
push and were not re-read; findings on them are in the earlier review.
4 earlier comment thread(s) were resolved: the lines they pointed at changed
and the finding did not recur.

Deterministic analyzers: 1 ran

Analyzer configuration is policy, and a change may not supply the policy it is
reviewed under, so no analyzer read this repository's own lint settings.

  • golangci-lint — ran: isolated: open-nitpick's own analyzer config
Read 2 changed files. 50 files had nothing to review. 2 findings: 1 warning, 1 nit. Analyzers: golangci-lint.

Findings: 1 warning, 1 nit

Files not reviewed
  • declaration:internal/vcs/github_checkout.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout.go
  • declaration:internal/vcs/github_checkout_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:cmd/nitpick/engineering_review.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/fix.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/improve.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/respond.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond.go
  • declaration:cmd/nitpick/review.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:18: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review_test.go:9: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/standards.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:internal/bundle/related.go:47: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/config/basepolicy.go:2: complete design task exceeds review.max_files_per_request: internal/config/basepolicy.go
  • declaration:internal/review/design_plan.go:2: complete design task exceeds review.max_files_per_request: internal/review/design_plan.go
  • declaration:internal/review/engine.go:26: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/integrity_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/policy_test.go:32: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/vcs/base_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/containment_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/github.go:16: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github_test.go:20: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:21: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:22: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:23: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/local_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/propose.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/propose.go
  • declaration:internal/vcs/snapshot_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/tree.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
Engineering practices
Engineering practices (engineering):
  Policy: /home/runner/work/open-nitpick/open-nitpick/.nitpick.yaml
  slop-tells: completed; 2/2 targets examined, 0 findings
  conventions: completed; 2/2 targets examined, 0 findings
  design-boundaries: completed; 2/2 targets examined, 0 findings
  commits: completed; 3/3 targets examined, 0 findings
  slop: completed; 2/2 targets examined, 0 findings
  design: partial; 11/60 targets examined, 2 findings
    design tasks or required context did not complete
    Scope limit: Go import graph only; dynamic calls and external dependency implementations are not resolved
    Scope limit: package inventory is not proof of complete architecture review
    Scope limit: imports include all selected Go sources regardless of build constraints
    Scope limit: internal/knowledge/indexes excluded: matched an ignore pattern
    Scope limit: source inventory is bounded to 4096 paths and 32 MiB; only Go source has a dependency graph
    Scope limit: tasks assess named declaration and caller interactions; completion is not proof of every package-level design property
    Scope limit: change scope follows changed source declarations and two caller hops; manifest changes expand package scope; deeper callers remain outside the declared assessment
    Scope limit: coupling candidates match signature and body-token shape within a Go package; a shape match does not establish a shared policy
    Scope limit: context includes two implementation-call hops within the root package and its direct imports, state writers and package contracts; deeper bodies, transitive imports, dynamic dispatch and reflection are outside the task scope; method selection does not type-check receivers; aliases and unknown returned reference types are not tracked as state writes
    model.correctness [file; advisory] internal/vcs/github_checkout.go:66: Transient git failure cached as permanent checkout miss
      readCheckoutTree caches nil for both missing commits and transient git failures, so one transient error permanently routes all reads of that commit through the API for the rest of the run. The warn log also misreports the cause as a missing commit, pointing the operator at a nonexistent misconfiguration.
    model.tests [file; advisory] internal/vcs/github_checkout_test.go:79: ListDir error ignored, isolation assertion can pass vacuously
      ListDir's error is discarded, so if the checkout path errors the test passes vacuously and the working-tree isolation property for directory listings goes unverified. Only the FileContent half of the guard is pinned.
  linters: completed; 2/2 targets examined, 0 findings
  security: not_selected; 0/0 targets examined, 0 findings
    no separate security assessment selected
Model usage is a provider-reported lower bound; SDK retries may add usage and no monetary tariff is assumed.
  openrouter/qwen/qwen3.8-27b: 1934 prompt tokens, 299 completion tokens; 1 calls with usage, 0 without usage, 0 failed
  openrouter/z-ai/glm-5.3-flash: 53100 prompt tokens, 3410 completion tokens; 3 calls with usage, 0 without usage, 0 failed
Design scope: Go import graph only; dynamic calls and external dependency implementations are not resolved
Design scope: package inventory is not proof of complete architecture review
Design scope: imports include all selected Go sources regardless of build constraints

Reviewed by open-nitpick.

Comment thread internal/vcs/github_checkout.go
Comment thread internal/vcs/github_checkout_test.go Outdated

@open-nitpick open-nitpick Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the 2 file(s) changed since the review at a7bd835, or still carrying findings from it.
1 other changed file(s) in this pull request were reviewed on an earlier
push and were not re-read; findings on them are in the earlier review.
2 earlier comment thread(s) were resolved: the lines they pointed at changed
and the finding did not recur.

Deterministic analyzers: 1 ran

Analyzer configuration is policy, and a change may not supply the policy it is
reviewed under, so no analyzer read this repository's own lint settings.

  • golangci-lint — ran: isolated: open-nitpick's own analyzer config
Read 2 changed files. 51 files had nothing to review. Nothing found in what was read. Analyzers: golangci-lint.
Files not reviewed
  • declaration:internal/vcs/github_checkout.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout.go
  • declaration:internal/vcs/github_checkout_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:cmd/nitpick/engineering_review.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/fix.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/improve.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/respond.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond.go
  • declaration:cmd/nitpick/review.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:18: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review_test.go:9: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/standards.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:internal/bundle/related.go:47: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/config/basepolicy.go:2: complete design task exceeds review.max_files_per_request: internal/config/basepolicy.go
  • declaration:internal/review/design_plan.go:2: complete design task exceeds review.max_files_per_request: internal/review/design_plan.go
  • declaration:internal/review/engine.go:26: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/integrity_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/policy_test.go:32: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/vcs/base_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/containment_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/github.go:16: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github_test.go:20: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:21: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:22: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:23: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/local_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/propose.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/propose.go
  • declaration:internal/vcs/snapshot_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/tree.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
Reported by the reviewer, then withheld after a domain expert disagreed
  • internal/vcs/github_checkout.go:61 — Expected checkout miss logs a warning claiming the checkout could not be read
    • Generated-code reviewer: The claim names no rule and matches none as written: the error is not swallowed, it is logged once per commit (the warned map) with its cause, and the message 'checkout could not be read; reading through the API' is accurate for the miss case too, since the checkout cannot supply that commit. 'Every normal fallback emits a warning' is also overstated: warnOnce deduplicates, so it logs once per commit, not per read.
Engineering practices
Engineering practices (engineering):
  Policy: /home/runner/work/open-nitpick/open-nitpick/.nitpick.yaml
  slop-tells: completed; 2/2 targets examined, 0 findings
  conventions: completed; 2/2 targets examined, 0 findings
  design-boundaries: completed; 2/2 targets examined, 0 findings
  commits: completed; 4/4 targets examined, 0 findings
  slop: completed; 2/2 targets examined, 0 findings
    Withheld by Generated-code reviewer: Expected checkout miss logs a warning claiming the checkout could not be read (The claim names no rule and matches none as written: the error is not swallowed, it is logged once per commit (the warned map) with its cause, and the message 'checkout could not be read; reading through the API' is accurate for the miss case too, since the checkout cannot supply that commit. 'Every normal fallback emits a warning' is also overstated: warnOnce deduplicates, so it logs once per commit, not per read.)
  design: partial; 12/62 targets examined, 0 findings
    design tasks or required context did not complete
    Scope limit: Go import graph only; dynamic calls and external dependency implementations are not resolved
    Scope limit: package inventory is not proof of complete architecture review
    Scope limit: imports include all selected Go sources regardless of build constraints
    Scope limit: internal/knowledge/indexes excluded: matched an ignore pattern
    Scope limit: source inventory is bounded to 4096 paths and 32 MiB; only Go source has a dependency graph
    Scope limit: tasks assess named declaration and caller interactions; completion is not proof of every package-level design property
    Scope limit: change scope follows changed source declarations and two caller hops; manifest changes expand package scope; deeper callers remain outside the declared assessment
    Scope limit: coupling candidates match signature and body-token shape within a Go package; a shape match does not establish a shared policy
    Scope limit: context includes two implementation-call hops within the root package and its direct imports, state writers and package contracts; deeper bodies, transitive imports, dynamic dispatch and reflection are outside the task scope; method selection does not type-check receivers; aliases and unknown returned reference types are not tracked as state writes
  linters: completed; 2/2 targets examined, 0 findings
  security: not_selected; 0/0 targets examined, 0 findings
    no separate security assessment selected
Model usage is a provider-reported lower bound; SDK retries may add usage and no monetary tariff is assumed.
  openrouter/qwen/qwen3.8-27b: 1804 prompt tokens, 215 completion tokens; 1 calls with usage, 0 without usage, 0 failed
  openrouter/z-ai/glm-5.3-flash: 38281 prompt tokens, 3852 completion tokens; 2 calls with usage, 0 without usage, 0 failed
Design scope: Go import graph only; dynamic calls and external dependency implementations are not resolved
Design scope: package inventory is not proof of complete architecture review
Design scope: imports include all selected Go sources regardless of build constraints

Reviewed by open-nitpick.

@open-nitpick open-nitpick Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the 1 file(s) changed since the review at 82c8efd.
3 other changed file(s) in this pull request were reviewed on an earlier
push and were not re-read; findings on them are in the earlier review.

Deterministic analyzers: 1 skipped

Analyzer configuration is policy, and a change may not supply the policy it is
reviewed under, so no analyzer read this repository's own lint settings.

  • golangci-lint — skipped: no files it analyzes were selected for review
Read 1 changed file. 1 file had nothing to review. Nothing found in what was read.
Engineering practices
Engineering practices (engineering):
  Policy: /home/runner/work/open-nitpick/open-nitpick/.nitpick.yaml
  slop-tells: completed; 1/1 targets examined, 0 findings
  conventions: not_applicable; 0/0 targets examined, 0 findings
    no files in a language with enabled convention probes
  design-boundaries: not_applicable; 0/0 targets examined, 0 findings
    change contains no Go source or module boundary changes
  commits: completed; 5/5 targets examined, 0 findings
  slop: completed; 1/1 targets examined, 0 findings
  design: completed; 1/1 targets examined, 0 findings
    Scope limit: Go import graph only; dynamic calls and external dependency implementations are not resolved
    Scope limit: package inventory is not proof of complete architecture review
    Scope limit: imports include all selected Go sources regardless of build constraints
    Scope limit: internal/knowledge/indexes excluded: matched an ignore pattern
    Scope limit: source inventory is bounded to 4096 paths and 32 MiB; only Go source has a dependency graph
    Scope limit: tasks assess named declaration and caller interactions; completion is not proof of every package-level design property
    Scope limit: change scope follows changed source declarations and two caller hops; manifest changes expand package scope; deeper callers remain outside the declared assessment
    Scope limit: coupling candidates match signature and body-token shape within a Go package; a shape match does not establish a shared policy
    Scope limit: context includes two implementation-call hops within the root package and its direct imports, state writers and package contracts; deeper bodies, transitive imports, dynamic dispatch and reflection are outside the task scope; method selection does not type-check receivers; aliases and unknown returned reference types are not tracked as state writes
  linters: not_applicable; 0/0 targets examined, 0 findings
    no configured analyzer reads these paths
  security: not_selected; 0/0 targets examined, 0 findings
    no separate security assessment selected
Model usage is a provider-reported lower bound; SDK retries may add usage and no monetary tariff is assumed.
  openrouter/z-ai/glm-5.3-flash: 56732 prompt tokens, 105 completion tokens; 1 calls with usage, 0 without usage, 0 failed
Design scope: Go import graph only; dynamic calls and external dependency implementations are not resolved
Design scope: package inventory is not proof of complete architecture review
Design scope: imports include all selected Go sources regardless of build constraints

Reviewed by open-nitpick.

Base automatically changed from perf/design-sources-one-tree-read to main October 6, 2026 14:22
An error occurred while trying to automatically change base from perf/design-sources-one-tree-read to main October 6, 2026 14:22
jdziat added 5 commits October 6, 2026 07:23
The GitHub provider answered every file read and directory listing with an API request, and a read with no revision named also fetched the pull request and its head commit first. Reads now come from the commit in the checkout when it holds that commit, listings from one ls-tree, and the head commit is asked for once per pull request. Anything the checkout cannot answer goes to the API as before.

Refs #167
The contents API reports a symlink as a file, so a listing from the checkout now includes it; reading one is still refused. The index lock no longer spans the git calls, so a slow tree read does not block reads of other commits.
The contents API types a submodule as a file, so the checkout listing includes it and sends its read to the API. A checkout that cannot supply the commit now logs once per commit instead of quietly paying for every read.
Only a commit the checkout does not hold is remembered as a miss. A failed ls-tree on a commit that is there is retried on the next read and logged once, and the isolation test now fails if the checkout did not answer.
@jdziat
jdziat force-pushed the perf/design-sources-from-checkout branch from 10ca48e to 2d26daa Compare October 6, 2026 14:24

@open-nitpick open-nitpick Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic analyzers: 1 ran

Analyzer configuration is policy, and a change may not supply the policy it is
reviewed under, so no analyzer read this repository's own lint settings.

  • golangci-lint — ran: isolated: open-nitpick's own analyzer config
Read 4 changed files. 439 files had nothing to review. 1 finding: 1 info. Analyzers: golangci-lint.

Findings: 1 info

Files not reviewed
  • declaration:internal/vcs/github.go:13: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:15: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:16: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:19: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github.go:22: complete design task exceeds review.max_files_per_request: internal/vcs/github.go
  • declaration:internal/vcs/github_checkout.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout.go
  • declaration:internal/vcs/github_checkout_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:internal/vcs/github_checkout_test.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/github_checkout_test.go
  • declaration:cmd/nitpick/actions.go:9: complete design task exceeds review.max_files_per_request: cmd/nitpick/actions.go
  • declaration:cmd/nitpick/appauth.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth.go
  • declaration:cmd/nitpick/appauth_test.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:11: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/appauth_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/appauth_test.go
  • declaration:cmd/nitpick/commits.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/commits.go
  • declaration:cmd/nitpick/commits_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/commits_test.go
  • declaration:cmd/nitpick/commits_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/commits_test.go
  • declaration:cmd/nitpick/commits_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/commits_test.go
  • declaration:cmd/nitpick/engineering.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering.go
  • declaration:cmd/nitpick/engineering.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering.go
  • declaration:cmd/nitpick/engineering_model.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_model.go
  • declaration:cmd/nitpick/engineering_review.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_review.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_review.go
  • declaration:cmd/nitpick/engineering_snapshot.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_snapshot.go
  • declaration:cmd/nitpick/engineering_test.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:15: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:16: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:18: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:20: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:23: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:24: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:29: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:39: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:42: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/engineering_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/engineering_test.go
  • declaration:cmd/nitpick/enginewiring_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/enginewiring_test.go
  • declaration:cmd/nitpick/enginewiring_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/enginewiring_test.go
  • declaration:cmd/nitpick/fastreview.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview.go
  • declaration:cmd/nitpick/fastreview.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview.go
  • declaration:cmd/nitpick/fastreview.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview.go
  • declaration:cmd/nitpick/fastreview_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview_test.go
  • declaration:cmd/nitpick/fix.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fix.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/fix.go
  • declaration:cmd/nitpick/fullreview.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/fullreview.go
  • declaration:cmd/nitpick/improve.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:12: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve.go
  • declaration:cmd/nitpick/improve_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/improve_test.go
  • declaration:cmd/nitpick/init.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/init.go
  • declaration:cmd/nitpick/init.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/init.go
  • declaration:cmd/nitpick/init.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/init.go
  • declaration:cmd/nitpick/init.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/init.go
  • declaration:cmd/nitpick/init_test.go:15: complete design task exceeds review.max_files_per_request: cmd/nitpick/init_test.go
  • declaration:cmd/nitpick/knowledge_wiring_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/knowledge_wiring_test.go
  • declaration:cmd/nitpick/knowledge_wiring_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/knowledge_wiring_test.go
  • declaration:cmd/nitpick/knowledge_wiring_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/knowledge_wiring_test.go
  • declaration:cmd/nitpick/main.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/main.go
  • declaration:cmd/nitpick/mcp.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp.go
  • declaration:cmd/nitpick/mcp.go:19: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp.go
  • declaration:cmd/nitpick/mcp.go:21: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp.go
  • declaration:cmd/nitpick/mcp.go:27: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp.go
  • declaration:cmd/nitpick/mcp_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp_test.go
  • declaration:cmd/nitpick/mcp_test.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp_test.go
  • declaration:cmd/nitpick/mcp_test.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp_test.go
  • declaration:cmd/nitpick/mcp_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/mcp_test.go
  • declaration:cmd/nitpick/repo_standards.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/repo_standards.go
  • declaration:cmd/nitpick/repo_standards.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/repo_standards.go
  • declaration:cmd/nitpick/repo_standards.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/repo_standards.go
  • declaration:cmd/nitpick/respond.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond.go
  • declaration:cmd/nitpick/respond.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond.go
  • declaration:cmd/nitpick/respond_policy_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_policy_test.go
  • declaration:cmd/nitpick/respond_policy_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_policy_test.go
  • declaration:cmd/nitpick/respond_policy_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_policy_test.go
  • declaration:cmd/nitpick/respond_policy_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_policy_test.go
  • declaration:cmd/nitpick/respond_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/respond_test.go
  • declaration:cmd/nitpick/review.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:15: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:16: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:17: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:18: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:19: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:20: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:21: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:23: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:29: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/review.go
  • declaration:cmd/nitpick/review_test.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/review_test.go:9: complete design task exceeds review.max_files_per_request: cmd/nitpick/review_test.go
  • declaration:cmd/nitpick/security.go:1: complete design task exceeds review.max_files_per_request: cmd/nitpick/security.go
  • declaration:cmd/nitpick/security.go:13: complete design task exceeds review.max_files_per_request: cmd/nitpick/security.go
  • declaration:cmd/nitpick/security.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/security.go
  • declaration:cmd/nitpick/security_test.go:10: complete design task exceeds review.max_files_per_request: cmd/nitpick/security_test.go
  • declaration:cmd/nitpick/security_test.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/security_test.go
  • declaration:cmd/nitpick/slop.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/slop.go
  • declaration:cmd/nitpick/slop.go:5: complete design task exceeds review.max_files_per_request: cmd/nitpick/slop.go
  • declaration:cmd/nitpick/slop.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/slop.go
  • declaration:cmd/nitpick/standards.go:2: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:cmd/nitpick/standards.go:3: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:cmd/nitpick/standards.go:6: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards.go
  • declaration:cmd/nitpick/standards_test.go:14: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards_test.go
  • declaration:cmd/nitpick/standards_test.go:4: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards_test.go
  • declaration:cmd/nitpick/standards_test.go:7: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards_test.go
  • declaration:cmd/nitpick/standards_test.go:8: complete design task exceeds review.max_files_per_request: cmd/nitpick/standards_test.go
  • declaration:internal/bundle/related.go:19: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/bundle/related.go:29: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/bundle/related.go:47: complete design task exceeds review.max_files_per_request: internal/bundle/related.go
  • declaration:internal/bundle/related_test.go:11: complete design task exceeds review.max_files_per_request: internal/bundle/related_test.go
  • declaration:internal/bundle/related_test.go:13: complete design task exceeds review.max_files_per_request: internal/bundle/related_test.go
  • declaration:internal/bundle/related_test.go:8: complete design task exceeds review.max_files_per_request: internal/bundle/related_test.go
  • declaration:internal/bundle/related_test.go:9: complete design task exceeds review.max_files_per_request: internal/bundle/related_test.go
  • declaration:internal/config/basepolicy.go:2: complete design task exceeds review.max_files_per_request: internal/config/basepolicy.go
  • declaration:internal/config/basepolicy.go:3: complete design task exceeds review.max_files_per_request: internal/config/basepolicy.go
  • declaration:internal/config/policy_test.go:30: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/policy_test.go:31: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/policy_test.go:32: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/policy_test.go:33: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/policy_test.go:34: complete design task exceeds review.max_files_per_request: internal/config/policy_test.go
  • declaration:internal/config/practices.go:7: complete design task exceeds review.max_files_per_request: internal/config/practices.go
  • declaration:internal/config/practices.go:8: complete design task exceeds review.max_files_per_request: internal/config/practices.go
  • declaration:internal/config/practices_test.go:2: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:3: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:4: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:5: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:6: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:7: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:8: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/config/practices_test.go:9: complete design task exceeds review.max_files_per_request: internal/config/practices_test.go
  • declaration:internal/evals/callers_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/callers_test.go
  • declaration:internal/evals/callers_test.go:2: complete design task exceeds review.max_files_per_request: internal/evals/callers_test.go
  • declaration:internal/evals/dump.go:11: complete design task exceeds review.max_files_per_request: internal/evals/dump.go
  • declaration:internal/evals/dump.go:13: complete design task exceeds review.max_files_per_request: internal/evals/dump.go
  • declaration:internal/evals/eval_test.go:3: complete design task exceeds review.max_files_per_request: internal/evals/eval_test.go
  • declaration:internal/evals/fixtures.go:7: complete design task exceeds review.max_files_per_request: internal/evals/fixtures.go
  • declaration:internal/evals/fixtures_dedup_test.go:12: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:14: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:15: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:16: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:17: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:18: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fixtures_dedup_test.go:19: complete design task exceeds review.max_files_per_request: internal/evals/fixtures_dedup_test.go
  • declaration:internal/evals/fullreview_eval_test.go:4: complete design task exceeds review.max_files_per_request: internal/evals/fullreview_eval_test.go
  • declaration:internal/evals/groundtruth_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:12: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:17: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:2: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:22: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:23: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:24: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:25: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:27: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:3: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:30: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:35: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:42: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:43: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:48: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:49: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:51: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:54: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:59: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:60: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:61: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:62: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:64: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:66: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:67: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:68: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:69: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:70: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:71: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:72: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/groundtruth_test.go:73: complete design task exceeds review.max_files_per_request: internal/evals/groundtruth_test.go
  • declaration:internal/evals/harness.go:11: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:12: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:13: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:14: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:15: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:27: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:30: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:5: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/harness.go:7: complete design task exceeds review.max_files_per_request: internal/evals/harness.go
  • declaration:internal/evals/infocorpus_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/infocorpus_test.go
  • declaration:internal/evals/infocorpus_test.go:2: complete design task exceeds review.max_files_per_request: internal/evals/infocorpus_test.go
  • declaration:internal/evals/multifile_eval_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/multifile_eval_test.go
  • declaration:internal/evals/multifile_test.go:1: complete design task exceeds review.max_files_per_request: internal/evals/multifile_test.go
  • declaration:internal/evals/multifile_test.go:3: complete design task exceeds review.max_files_per_request: internal/evals/multifile_test.go
  • declaration:internal/evals/rejudge.go:22: complete design task exceeds review.max_files_per_request: internal/evals/rejudge.go
  • declaration:internal/evals/rejudge_test.go:23: complete design task exceeds review.max_files_per_request: internal/evals/rejudge_test.go
  • declaration:internal/evals/score.go:59: complete design task exceeds review.max_files_per_request: internal/evals/score.go
  • declaration:internal/evals/security_eval_test.go:7: complete design task exceeds review.max_files_per_request: internal/evals/security_eval_test.go
  • declaration:internal/evals/tune_test.go:12: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:13: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:14: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:6: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:7: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/evals/tune_test.go:9: complete design task exceeds review.max_files_per_request: internal/evals/tune_test.go
  • declaration:internal/linters/gate_test.go:18: complete design task exceeds review.max_files_per_request: internal/linters/gate_test.go
  • declaration:internal/review/approve_residual_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:13: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:3: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:4: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_residual_test.go:8: complete design task exceeds review.max_files_per_request: internal/review/approve_residual_test.go
  • declaration:internal/review/approve_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/approve_test.go
  • declaration:internal/review/approve_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/approve_test.go
  • declaration:internal/review/budget_apply.go:1: complete design task exceeds review.max_files_per_request: internal/review/budget_apply.go
  • declaration:internal/review/budget_apply.go:3: complete design task exceeds review.max_files_per_request: internal/review/budget_apply.go
  • declaration:internal/review/classfilter_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/classfilter_test.go
  • declaration:internal/review/classfilter_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/classfilter_test.go
  • declaration:internal/review/design_evidence_test.go:3: complete design task exceeds review.max_files_per_request: internal/review/design_evidence_test.go
  • declaration:internal/review/design_plan.go:2: complete design task exceeds review.max_files_per_request: internal/review/design_plan.go
  • declaration:internal/review/design_plan_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:16: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:17: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:4: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/design_plan_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/design_plan_test.go
  • declaration:internal/review/discardnotice_test.go:18: complete design task exceeds review.max_files_per_request: internal/review/discardnotice_test.go
  • declaration:internal/review/discardnotice_test.go:22: complete design task exceeds review.max_files_per_request: internal/review/discardnotice_test.go
  • declaration:internal/review/engine.go:26: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:34: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:35: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:36: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:37: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:58: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:68: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine.go:80: complete design task exceeds review.max_files_per_request: internal/review/engine.go
  • declaration:internal/review/engine_test.go:17: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:18: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:21: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:22: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:23: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:24: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:26: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:27: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:28: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:29: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:30: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:37: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:38: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:39: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/engine_test.go:40: complete design task exceeds review.max_files_per_request: internal/review/engine_test.go
  • declaration:internal/review/fast_review_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:16: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:8: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/fast_review_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/fast_review_test.go
  • declaration:internal/review/gitpolicy_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/gitpolicy_test.go
  • declaration:internal/review/gitpolicy_test.go:8: complete design task exceeds review.max_files_per_request: internal/review/gitpolicy_test.go
  • declaration:internal/review/incomplete_test.go:14: complete design task exceeds review.max_files_per_request: internal/review/incomplete_test.go
  • declaration:internal/review/incomplete_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/incomplete_test.go
  • declaration:internal/review/incomplete_test.go:8: complete design task exceeds review.max_files_per_request: internal/review/incomplete_test.go
  • declaration:internal/review/incremental_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:13: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:14: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:16: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:17: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:18: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:21: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:22: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:23: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/incremental_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/incremental_test.go
  • declaration:internal/review/integrity_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:6: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/integrity_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/integrity_test.go
  • declaration:internal/review/noclaims_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/noclaims_test.go
  • declaration:internal/review/noclaims_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/noclaims_test.go
  • declaration:internal/review/paths_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/paths_test.go
  • declaration:internal/review/paths_test.go:3: complete design task exceeds review.max_files_per_request: internal/review/paths_test.go
  • declaration:internal/review/policy.go:4: complete design task exceeds review.max_files_per_request: internal/review/policy.go
  • declaration:internal/review/policy_test.go:10: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:11: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:12: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:13: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:14: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:15: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:16: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:17: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:18: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:19: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:20: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:21: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:27: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:28: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:29: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:32: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/policy_test.go:33: complete design task exceeds review.max_files_per_request: internal/review/policy_test.go
  • declaration:internal/review/priorspend_test.go:4: complete design task exceeds review.max_files_per_request: internal/review/priorspend_test.go
  • declaration:internal/review/priorspend_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/priorspend_test.go
  • declaration:internal/review/priorspend_test.go:6: complete design task exceeds review.max_files_per_request: internal/review/priorspend_test.go
  • declaration:internal/review/priorspend_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/priorspend_test.go
  • declaration:internal/review/progress_test.go:3: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:4: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:5: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:6: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:7: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/progress_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/progress_test.go
  • declaration:internal/review/removals_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/removals_test.go
  • declaration:internal/review/removals_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/removals_test.go
  • declaration:internal/review/render.go:42: complete design task exceeds review.max_files_per_request: internal/review/render.go
  • declaration:internal/review/route.go:3: complete design task exceeds review.max_files_per_request: internal/review/route.go
  • declaration:internal/review/route_test.go:9: complete design task exceeds review.max_files_per_request: internal/review/route_test.go
  • declaration:internal/review/triageskip_test.go:1: complete design task exceeds review.max_files_per_request: internal/review/triageskip_test.go
  • declaration:internal/review/triageskip_test.go:2: complete design task exceeds review.max_files_per_request: internal/review/triageskip_test.go
  • declaration:internal/review/validate_test.go:28: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:29: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:30: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:31: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:34: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:35: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:36: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/review/validate_test.go:47: complete design task exceeds review.max_files_per_request: internal/review/validate_test.go
  • declaration:internal/vcs/base_test.go:13: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:16: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/base_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/base_test.go
  • declaration:internal/vcs/containment_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/containment_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/containment_test.go
  • declaration:internal/vcs/github_test.go:11: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:12: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:13: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:17: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:19: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:20: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:21: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:22: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:23: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:27: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:28: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/github_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/github_test.go
  • declaration:internal/vcs/incremental_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/incremental_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/incremental_test.go
  • declaration:internal/vcs/integrity_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:10: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:11: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/integrity_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/integrity_test.go
  • declaration:internal/vcs/local.go:10: complete design task exceeds review.max_files_per_request: internal/vcs/local.go
  • declaration:internal/vcs/local_test.go:10: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:11: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:12: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:13: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:14: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:7: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/local_test.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/local_test.go
  • declaration:internal/vcs/progress_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/progress_test.go
  • declaration:internal/vcs/progress_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/progress_test.go
  • declaration:internal/vcs/progress_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/progress_test.go
  • declaration:internal/vcs/propose.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/propose.go
  • declaration:internal/vcs/propose_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/propose_test.go
  • declaration:internal/vcs/snapshot_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/snapshot_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/snapshot_test.go
  • declaration:internal/vcs/tree.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:6: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:8: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree.go:9: complete design task exceeds review.max_files_per_request: internal/vcs/tree.go
  • declaration:internal/vcs/tree_test.go:1: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/tree_test.go:2: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/tree_test.go:3: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/tree_test.go:4: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/tree_test.go:5: complete design task exceeds review.max_files_per_request: internal/vcs/tree_test.go
  • declaration:internal/vcs/vcs.go:32: complete design task exceeds review.max_files_per_request: internal/vcs/vcs.go
  • file:cmd/nitpick/fastreview_live_test.go: complete design task exceeds review.max_files_per_request: cmd/nitpick/fastreview_live_test.go
  • file:cmd/nitpick/queue_test.go: complete design task exceeds review.max_files_per_request: cmd/nitpick/queue_test.go
  • file:cmd/nitpick/slop_test.go: complete design task exceeds review.max_files_per_request: cmd/nitpick/slop_test.go
  • file:internal/evals/bigpr_eval_test.go: complete design task exceeds review.max_files_per_request: internal/evals/bigpr_eval_test.go
  • file:internal/evals/harness_pin_test.go: complete design task exceeds review.max_files_per_request: internal/evals/harness_pin_test.go
  • file:internal/evals/probe_eval_test.go: complete design task exceeds review.max_files_per_request: internal/evals/probe_eval_test.go
  • file:internal/review/design_budget.go: complete design task exceeds review.max_files_per_request: internal/review/design_budget.go
  • file:internal/review/practices_test.go: complete design task exceeds review.max_files_per_request: internal/review/practices_test.go
Engineering practices
Engineering practices (engineering):
  Policy: /home/runner/work/open-nitpick/open-nitpick/.nitpick.yaml
  slop-tells: completed; 4/4 targets examined, 0 findings
  conventions: completed; 3/3 targets examined, 0 findings
  design-boundaries: completed; 3/3 targets examined, 0 findings
  commits: completed; 5/5 targets examined, 0 findings
  slop: completed; 4/4 targets examined, 0 findings
  design: partial; 55/493 targets examined, 1 findings
    design tasks or required context did not complete
    Scope limit: Go import graph only; dynamic calls and external dependency implementations are not resolved
    Scope limit: package inventory is not proof of complete architecture review
    Scope limit: imports include all selected Go sources regardless of build constraints
    Scope limit: internal/knowledge/indexes excluded: matched an ignore pattern
    Scope limit: source inventory is bounded to 4096 paths and 32 MiB; only Go source has a dependency graph
    Scope limit: tasks assess named declaration and caller interactions; completion is not proof of every package-level design property
    Scope limit: change scope follows changed source declarations and two caller hops; manifest changes expand package scope; deeper callers remain outside the declared assessment
    Scope limit: coupling candidates match signature and body-token shape within a Go package; a shape match does not establish a shared policy
    Scope limit: context includes two implementation-call hops within the root package and its direct imports, state writers and package contracts; deeper bodies, transitive imports, dynamic dispatch and reflection are outside the task scope; method selection does not type-check receivers; aliases and unknown returned reference types are not tracked as state writes
    model.correctness [file; advisory] docs/findings.md:2649: File count contradicts earlier measurement
      The new paragraph reports 398 files for the same 93-directory tree that the preceding section records as 396 files. This contradiction makes the performance comparison between the 290ms and 16.0s runs unreproducible, as a reader cannot determine if the tree changed or if one count is erroneous.
  linters: completed; 3/3 targets examined, 0 findings
  security: not_selected; 0/0 targets examined, 0 findings
    no separate security assessment selected
Model usage is a provider-reported lower bound; SDK retries may add usage and no monetary tariff is assumed.
  openrouter/qwen/qwen3.8-27b: 1800 prompt tokens, 197 completion tokens; 1 calls with usage, 0 without usage, 0 failed
  openrouter/z-ai/glm-5.3-flash: 162158 prompt tokens, 4211 completion tokens; 3 calls with usage, 0 without usage, 0 failed
Design scope: Go import graph only; dynamic calls and external dependency implementations are not resolved
Design scope: package inventory is not proof of complete architecture review
Design scope: imports include all selected Go sources regardless of build constraints

Reviewed by open-nitpick.

Comment thread docs/findings.md Outdated

@open-nitpick open-nitpick Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the 1 file(s) changed since the review at 2d26daa, or still carrying findings from it.
3 other changed file(s) in this pull request were reviewed on an earlier
push and were not re-read; findings on them are in the earlier review.
1 earlier comment thread(s) were resolved: the lines they pointed at changed
and the finding did not recur.

Deterministic analyzers: 1 skipped

Analyzer configuration is policy, and a change may not supply the policy it is
reviewed under, so no analyzer read this repository's own lint settings.

  • golangci-lint — skipped: no files it analyzes were selected for review
Read 1 changed file. 1 file had nothing to review. Nothing found in what was read.
Engineering practices
Engineering practices (engineering):
  Policy: /home/runner/work/open-nitpick/open-nitpick/.nitpick.yaml
  slop-tells: completed; 1/1 targets examined, 0 findings
  conventions: not_applicable; 0/0 targets examined, 0 findings
    no files in a language with enabled convention probes
  design-boundaries: not_applicable; 0/0 targets examined, 0 findings
    change contains no Go source or module boundary changes
  commits: completed; 6/6 targets examined, 0 findings
  slop: completed; 1/1 targets examined, 0 findings
  design: completed; 1/1 targets examined, 0 findings
    Scope limit: Go import graph only; dynamic calls and external dependency implementations are not resolved
    Scope limit: package inventory is not proof of complete architecture review
    Scope limit: imports include all selected Go sources regardless of build constraints
    Scope limit: internal/knowledge/indexes excluded: matched an ignore pattern
    Scope limit: source inventory is bounded to 4096 paths and 32 MiB; only Go source has a dependency graph
    Scope limit: tasks assess named declaration and caller interactions; completion is not proof of every package-level design property
    Scope limit: change scope follows changed source declarations and two caller hops; manifest changes expand package scope; deeper callers remain outside the declared assessment
    Scope limit: coupling candidates match signature and body-token shape within a Go package; a shape match does not establish a shared policy
    Scope limit: context includes two implementation-call hops within the root package and its direct imports, state writers and package contracts; deeper bodies, transitive imports, dynamic dispatch and reflection are outside the task scope; method selection does not type-check receivers; aliases and unknown returned reference types are not tracked as state writes
  linters: not_applicable; 0/0 targets examined, 0 findings
    no configured analyzer reads these paths
  security: not_selected; 0/0 targets examined, 0 findings
    no separate security assessment selected
Model usage is a provider-reported lower bound; SDK retries may add usage and no monetary tariff is assumed.
  openrouter/z-ai/glm-5.3-flash: 57139 prompt tokens, 362 completion tokens; 1 calls with usage, 0 without usage, 0 failed
Design scope: Go import graph only; dynamic calls and external dependency implementations are not resolved
Design scope: package inventory is not proof of complete architecture review
Design scope: imports include all selected Go sources regardless of build constraints

Reviewed by open-nitpick.

@jdziat
jdziat merged commit 9c3d98c into main Oct 7, 2026
9 checks passed
@jdziat
jdziat deleted the perf/design-sources-from-checkout branch October 7, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop reading the whole repository before a one-file review

1 participant