Repository navigation
Include tag name in per-tag feed titles, matching category feeds - #427
Open
hikmetba-bit wants to merge 1 commit into
Open
hikmetba-bit wants to merge 1 commit into
hikmetba-bit wants to merge 1 commit into
Conversation
Category feeds already append the category name to the feed title (site title | Category). Per-tag feeds (generated when feed.tags is enabled) had no equivalent, so their <title> was just the bare site title with no indication of which tag the feed is for. page.tags is set by the generator to a single tag name string for these pages (see generate_tag_feed/make_page), the same shape as page.category, so the added Liquid block mirrors the existing category block exactly. Fixes jekyll#406. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #406.
Category feeds already append the category name to the feed title (
site title | Category, via the{% if page.category %}block infeed.xml). Per-tag feeds (generated whenfeed.tagsis enabled) had no equivalent — their<title>was just the bare site title, with no indication of which tag the feed is actually for.Fix
page.tagsis set by the generator (generate_tag_feed→make_page) to a single tag name string for these generated pages — the same shape aspage.category. Added a Liquid block mirroring the existing category block exactly, appending the (capitalized) tag name to the title.Testing
<title type="html">My awesome site | Test</title>for thetesttag's feed.My awesome site), and passes with it.bundle exec rspec spec/— 72 examples, 0 failures, 1 pending (pre-existing, unrelated: a validation spec skipped becauselibcurlisn't available on Windows).bundle exec rubocopon the changed files: no offenses.🤖 Generated with Claude Code