fix(messenger): flush the IndexationRequest spool after each worker message - #229
Merged
Merged
Conversation
…essage IndexationRequest dispatched while handling a message in a Messenger worker were never sent: the spool was only flushed on kernel/console terminate, and the in-memory transport is reset between messages. Fix #207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #207
Problem
An
IndexationRequestdispatched from a handler running inmessenger:consumewas never sent:IndexationRequestSpoolSubscriberonly flushes the spool onkernel.terminate/console.terminate, and the in-memory transport is reset between two worker messages. The requests were lost silently.Fix
IndexationRequestSpoolSubscribernow also listens to:WorkerMessageHandledEvent: flush the spool (same logic asonTerminate());WorkerMessageFailedEvent: reject the requests queued while handling the failed message, so they are not sent along with the next handled message. The failed message will be retried (or sent to the failure transport) and will dispatch them again.The second point is a design choice, feedback welcome.
Test plan
MemoryQueuingFunctionalTest