Repository navigation
fix(knowledge): distinguish observations from review activity - #6974
Merged
Merged
Conversation
Collaborator
Author
Helm Manifest DiffNo manifest changes detected across 17 application(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Monolith entity page could show an October 11 observation date after a later review because the entity response omitted last_reviewed_at. The daily chart was labelled "Facts written per day" while its query groups the whole public corpus by observed_at and current verification state.
Expose the existing public last_reviewed_at field, display review dates separately in the entity summary and each fact, and label the chart "Public facts by observation date". Keep original evidence dates, corpus filters, entity associations, ordering, review behavior and cache policy unchanged. The payload-derived ETag now changes when the displayed review timestamp changes.
Validation:
b3c7fb275024e4c1ec41da0425b63dee1ef76192: Executed 389 out of 460 tests, all 460 passed. Image builds, repository gates and browser checks passed; zero deployment-manifest changes across 17 applications. BuildBuddy run. The runner recovered automatically from missing remote-cache inputs; the HTTP smoke target passed its automatic retry after a healthz ReadTimeout. No manual rerun.Investigation limits: the entity view is linked current public facts, subjects first, capped at sixty; the chart is all public facts in its observation-date window, including historical rows. Neither measures new writes or review events. Fresh MCP reads at 2026-10-13 16:04 UTC found 22 due KG jobs (17 unclaimed and five older locked rows); recent replica log samples did not establish current kg_full refusals. The public entity HTTP read returned 403 and was not retried or bypassed, so exact live entity membership, bar contributors and cache headers remain unverified. This patch addresses confirmed display semantics, not a claimed diagnosis of the entire live discrepancy.
Draft only. No merge, deployment, live setting, credential, budget, limit, permit release or recovery. Existing drafts #6973/#6963 and receipt 822/#6972 holds remain unchanged.