Repository navigation
fix(monolith): close CD probe Kubernetes clients - #6976
Merged
Merged
Conversation
Collaborator
Author
Helm Manifest DiffNo manifest changes detected across 17 application(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deployment-observation recording and the adjacent chart-lag poll each allocated a KubernetesClient without closing it. Repeated polls could leave aiohttp sessions and connectors unclosed, matching the reported warnings.
Close both poll-scoped clients in finally blocks, including failure and cancellation paths. Per-app write failure isolation is preserved. This fixes a demonstrated lifecycle leak; it does not establish the cause of the backend exit-code-1 restarts or change uncertain factory permits.
Validation: 43 CD-health tests pass locally. New success, read/collection failure, and cancellation regression cases failed before each fix. The existing per-app persistence failure test now also asserts cleanup. Formatting and git diff checks passed. Full repository CI and live rollout remain pending. The coordinating thread owns merging.