Skip to content

Areas that require further investigation #62

Description

@montyly
  • Limit the access to non-standard ERC20. Use the token integration checklist to evaluate collateral that should be allowed. For example, the system will not work as expected with tokens that take a fee on transfer
  • Use Echidna to evaluate the impact of rounding. Several operations have a loss of precision due to the arithmetic rounding. As a result a user might receive less than expected, and this area should be investigated further
  • Consider adding limits on how much assets can be withdrawn by AssetPool.claim. If the owner of the AssetPool is compromised, he can drain everything. A time-based limit of withdrawal might reduce the risks (note that the coverage pool was out of scope of my review)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions