Repository navigation
Conversation
|
|
cayo-aura
marked this pull request as ready for review
October 18, 2026 22:56
Contributor
|
No linked issues found. Please add the corresponding issues in the pull request description. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CloudWatch scope validation can call
PutMetricAlarmon an existing alarm and start a Logs Insights query. Externally managed SNS receivers should not need those side effects. Explicit polling flags are also lost on initial provider provisioning. Separately, late source transitions can replace a newer current state and reach workflows because ingestion time is used for current-alert selection.Related to #6879. Submitted for maintainer review; production acceptance remains subject to the limitations below.
Changes
authentication.webhook_only: true: no AWS clients/scopes, querying or automatic webhook installation. Existing API mode remains the default.pulling_enabledfor JSON/YAML initial provisioning and updates, including strict boolean/string parsing.KEEP_SOURCE_EVENT_ORDERING_PROVIDERS=cloudwatch, currently PostgreSQL only. A per-tenant/fingerprint advisory lock protects admission through the existing enqueue boundary without adding tables, another receiver or an external ledger.sourceEventOrdering.acceptedandrecoveryEligiblefor notification policy.only_on_changeandseverity_changedcomparisons to the persisted triggering event and previous accepted source transition, excluding rejected history and avoiding ingestion-clock ordering. Rejected rows remain inspectable.Validation
KEEP_TEST_ORDERING_POSTGRES_URLpointing at a disposable database; they create/drop isolated schemas and skip when the explicit test DSN is absent.Limitations and production acceptance
Do not enable source ordering in production based on this PR. It implements admission and current-state protection, not a complete transactional delivery design.
keepcursor. A reviewed identity/time handoff is required; this implementation refuses that conflict rather than rewriting historical alerts or silently accepting it.Receiving an initial OK remains valid.
recoveryEligiblesupplies episode context; the workflow decides whether to notify. This contribution is for upstream review and is not selected as a production fork/image.