You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 12, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Oct 12, 2025. It is now read-only.
Upload the file via providing url instead of sending file via form #32
Sounds good! My only concern is that it could be used to DoS a site by sending a URL with a massive file, but so we'd probably need to make a "maximum URL download size" option for Exfile
A validate_size validator would have to run after the file is downloaded from the URL -- my particular concern is that an end user could enter a URL (either maliciously or by accident) to a file that is larger than the available space on the server, for example. The reason there isn't a limit right now is because Plug has its own limit for POST bodies and most reverse proxies do as well.
Activity
keichan34 commentedon Jul 22, 2016
Sounds good! My only concern is that it could be used to DoS a site by sending a URL with a massive file, but so we'd probably need to make a "maximum URL download size" option for Exfile
asiniy commentedon Jul 22, 2016
I thought about implementing
validate_size()validator, likevalidate_content_type, which I'm implementing right nowasiniy commentedon Jul 22, 2016
It's easier to specify file size for each model instead of creating one global value
keichan34 commentedon Jul 22, 2016
A
validate_sizevalidator would have to run after the file is downloaded from the URL -- my particular concern is that an end user could enter a URL (either maliciously or by accident) to a file that is larger than the available space on the server, for example. The reason there isn't a limit right now is because Plug has its own limit for POST bodies and most reverse proxies do as well.asiniy commentedon Jul 22, 2016
@keichan34 hm, you're right here. We already have file limit, isn't it?
keichan34 commentedon Jul 22, 2016
I'm not sure I understand. Which file limit?
keichan34 commentedon Jul 22, 2016
Oh, I see, yeah. I think we can use that instead of making a new global configuration variable.
asiniy commentedon Jul 22, 2016
@keichan34 yes, but I still want to implement this feature.
keichan34 commentedon Jul 22, 2016
Got it. Thanks! :)
asiniy commentedon Jul 22, 2016
Mark this issue as milestone?