Repository navigation
fix: only pass libscrapli a logger callback when a logger is configured - #20
Merged
Merged
Conversation
…when o.Logger != nil
araustin01
added
bug
…uffer-lending sites (CLI/NETCONF FetchOperation and both ResultRaw reconstruction paths); bumped libscrapli
alistairking
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ksqueegee agent processes regularly panic with an unrecoverable whole-process memory-corruption fault.
Solution
Options.Applysetopts.loggerCallbackunconditionally on everyOpen, regardless of whether the caller ever supplied a logger. This change makes both the dispatcher registration and the callback pointer conditional ono.Logger != nil.Libscrapli adds the
SA_ONSTACKflag to the two signal handlers Zig installs.