chore/increase offline tests coverage

[alanpeixinho]

Increase coverage test on offline testing.
testing_offline has gone from 61% to 69% total coverage.

We are now including:

• mail/web exporting check.
• deletion check.

Name Stmts Miss Cover
----------------------------------------------------------------   
regzbot/__init__.py 2022 461 77%
regzbot/_rbcmd.py 366 44 88%
regzbot/_repsources/_bugzilla.py 332 276 17%
regzbot/_repsources/_generic.py 23 0 100%
regzbot/_repsources/_github.py 303 244 19%
regzbot/_repsources/_gitlab.py 309 251 19%
regzbot/_repsources/_lore.py 409 132 68%
regzbot/_repsources/_trackers.py 77 55 29%
regzbot/commandl.py 86 11 87%
regzbot/export_csv.py 93 2 98%
regzbot/export_mail.py 345 42 88%
regzbot/export_web.py 720 40 94%
----------------------------------------------------------------   
TOTAL 5085 1558 69%

The _repsources/*.py files should be more effectively covered by testing_trackers.py.

How to run

Execute tests

PYTHONPATH=. coverage run regzbot/commandl.py test --offline

Compile report

coverage report

[tales-aparecida]

I think db_ensure_cursor needs its own commit.

Edit: _web_days_delta as well

Edit2: I think you need to break the second commit in more parts. It's very unclear what is dead code being removed and what is changing

[tales-aparecida]

testdata/expected/results-offline.csv was already kind of big and you've 4x it, into 12k lines (1.3MB). Any way to break it into smaller files? If not in this MR, at least a plan on how we could achieve that

[tales-aparecida]

Too many changes in a single commit

[alanpeixinho]

testdata/expected/results-offline.csv was already kind of big and you've 4x it, into 12k lines (1.3MB). Any way to break it into smaller files? If not in this MR, at least a plan on how we could achieve that

I have considered that.
The main problem here is, in the current implementation the file diff between expected and result is used as a strategy to analyze differences.
Breaking into per test files might help reducing the big file problem, but I am not sure this is a good solution here.
Do you have any suggestions?

[alanpeixinho]

Too many changes in a single commit

Broke into separate commits for each change.

[tales-aparecida]

Too many changes in a single commit

Broke into separate commits for each change.

Much better, thanks! But the two refactor commits are still a bit confusing as to what is just being extracted/moved into a helper, and what is changing more dramatically. Do you think you can split them a bit more?

[alanpeixinho]

Too many changes in a single commit

Broke into separate commits for each change.

Much better, thanks! But the two refactor commits are still a bit confusing as to what is just being extracted/moved into a helper, and what is changing more dramatically. Do you think you can split them a bit more?

Just to be sure.
Are you referring to these commits?

• b07cdb9 — refactor: split mail exporter for offline testing
• 4d1334d — refactor: split web exporter for offline testing

[tales-aparecida]

@alanpeixinho

Just to be sure.
Are you referring to these commits?

• b07cdb9 — refactor: split mail exporter for offline testing
• 4d1334d — refactor: split web exporter for offline testing

yep!

[alanpeixinho]

Broke it even further, as requested.