feat(sql): expose batch size to sql builder - #8648
Open
dentiny wants to merge 5 commits into
Open
Conversation
github-actions
Bot
added
A-python
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
lance-gatekeeper
Bot
removed
the
K-changes
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
lance-gatekeeper
Bot
removed
the
K-changes
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
Shared scanner-boundary validation now rejects invalid row batch sizes before SQL or direct-provider execution, eliminating the prior zero-row data-loss path. Rust and Python regressions cover both bounds and the explicit byte-limit precedence.
lance-gatekeeper
Bot
added
the
K-approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8649
Hi team, I'm using a forked lance data viewer to view lance dataset.
One pain point is memory consumption for queries, streaming execution is sth I've been investigating.
Scanner exposes
batch_sizeandbatch_size_bytes, but SqlQueryBuilder does not. SQL queries therefore use DataFusion/Lance defaults, potentially producing large batches even when consumers incrementally poll the stream.I'm wondering if we could expose equivalent options on
SqlQueryBuilderand propagate them to bothLanceTableProviderand DataFusionSessionConfig. This would let streaming consumers reduce peak and retained memory without limiting the total query result.