fix(io): normalize OpenDAL listed paths - #8654
Conversation
|
Blocked: the current head is held by an unrelated intermittent macOS BQ test failure that this App cannot rerun. Remote head 1d7f8e3 contains the current main tip b945b3e. The mac-build (stable) Check failed vector::bq::storage::tests::test_accurate_approx_mode_reduces_binary_lut_quantization_error with accurate_error=0.07851982 and normal_error=0.06913757; this PR changes only lance-io, and the identical base SHA passed the macOS Check. I fetched and verified base ancestry, inspected the live log, ran both the failed BQ test and the OpenDAL regression successfully, and pushed the assigned branch, which was already up to date. A failed-workflow rerun was requested, but the GitHub App lacks Actions rerun permission. The smallest unblock is for a maintainer to rerun the failed mac-build (stable) job; alternatively, rerun the full Rust workflow on this head. |
Summary
Path::from_url_path~Root cause
object_store_opendalrebuilds OpenDAL listing entries withPath::from, which percent-encodes reserved characters. Lance deliberately constructs the dataset base withPath::from_url_path, leaving the decoded UTF-8 path inPath. The encoded listing location therefore could not match or be made relative to the raw dataset base.Validation
cargo test -p lance-io object_store::opendal_store::tests::test_list_preserves_raw_locationscargo test -p lance-io --lib -- --skip uring::tests(201 passed)cargo check -p lance-io --all-features --testscargo fmt --all -- --checkcargo clippy --all --tests --benches -- -D warningsThe complete
lance-iolibrary test command cannot finish in this container because io_uring initialization is denied by the environment; the non-io_uring library suite passes.Fixes #8652