feat: add column slice stitching - #8660
Open
Xuanwo wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
A-encoding
![lance-gatekeeper[bot]](https://avatars.githubusercontent.com/in/4433141?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lance-gatekeeper
Bot
added
the
K-changes
lance-gatekeeper
Bot
removed
the
K-changes
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The revision closes the schema-metadata loss path across V2.0–V2.3 and restores stable row-ID loading for readers that add _rowid after opening. The encoded stitching path now preserves the relevant schema and row-identity contracts.
lance-gatekeeper
Bot
added
K-approved
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the Rust storage-layer artifact stitching proposed in Discussion #8615. Long-running fragment-local rewrites can stage immutable physical row slices and publish only after exact, gap-free coverage has been validated against the fragment snapshot.
Compatible current-version files are concatenated by relocating encoded pages and regenerating metadata and the footer, while unsupported layouts use the existing ordered decode/re-encode fallback. Binary-copy compaction now delegates encoded-file compatibility and footer handling to the same primitive without adopting the column-slice lifecycle.
The public surface in this PR is intentionally Rust-only. Python and Java bindings are deferred until the contract has settled.