Repository navigation
1.18.1: honest series target progress, generated-cover title alignment, store CSS lint clean - #46
Merged
Merged
Conversation
The shelf header summed every book's words over only the targeted books' targets, so one 60k target in a 353k-word series read 588%. Pull the line into a pure shelfMetaText helper that measures progress over targeted books and labels partial coverage targeted. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The community-store review lints styles.css with stylelint + stylelint-no-unsupported-browser-features at the Chromium of minAppVersion; ESLint never read it, so CSS warnings only surfaced after release. Add both as devDeps with a .stylelintrc.json (Chrome 128 for the 1.7.4 floor, duplicate-property core rule) and fold `lint:css` (warnings fail) into `npm run lint`, which CI and the version-bump runbook already gate on. AGENTS.md gotcha 20 records it. Fixes the two warnings reported against 1.18.0: - hero "Add to series…" used text-decoration: underline dotted (partial on 1.7.4) -> a dotted bottom border (fit-content keeps it text-width) - card placeholder declared display twice; the -webkit-box clamp overrode flex so the title never bottom-aligned. The clamp moves to an inner span. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…t, store CSS lint clean Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 1.18.1
A patch on top of 1.18.0. Merging moves
manifest.jsononmainto 1.18.1, which is what the community store reads.Fixed
displayrule was overriding the flex layout.text-decorationpartial support on 1.7.4, and a duplicatedisplay.Tooling
npm run lintnow also runslint:css: stylelint +stylelint-no-unsupported-browser-featuresat the Chromium ofminAppVersion. This mirrors the store's CSS check, and warnings fail. CI and the release workflow already gate onnpm run lint. See AGENTS.md gotcha 20.Verification
3 books · 1,792 words · 1,792 / 90,000 targeted (2%), the placeholder title is bottom-aligned with the 5-line clamp intact, and the "Add to series…" dotted border spans only the text.🤖 Generated with Claude Code