Repository navigation
fix(docs): stop hiding the footer sidebar collapse button - #1148
Conversation
…our own hide-native-controls rule Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
@faraday review |
|
⚡ Running fastpass on this PR first (https://zeus.dev.dev.sparkinfra.net/#/instance?id=wired-actuator-ww). A full council convenes only if fastpass assesses the risk at critical or above. Post a new comment '@faraday full review' to convene one anyway. |
|
📌 Bolt Status 2026-10-09 05:29:49 UTC — ⚡ Agent |
Faraday reviewfastpass advisory - comment-only, never blocks a merge. To retire a finding, either fix it or reply explaining why it is wrong: a rebuttal gets an agree or disagree answer on the thread, and if you reply again after a disagreement we concede. Acknowledging it ("will fix") or resolving the thread does not retire it on its own. This comment is edited in place every round; inline findings still post as new comments each round. Faraday score: 5/5 (clean) - 5 nothing blocking open | 4 non-blocking only | 3 one blocking open | 2 two | 1 a P0 or 3+ blocking; never drops without a new blocker
🦕 Congratulations @patcapulong - you caught a Shantungosaurus! (common)
View your collection: https://zeus.dev.dev.sparkinfra.net/#/dinodex/patcapulong This summary supersedes the per-round summary blocks on the faraday reviews above; those are left in place as history and are not edited. |
|
The collapse button in the docs sidebar footer does nothing on production. The icon renders, but clicking it has no effect.
Our "hide sidebar controls" rule in
mintlify/style.cssincludes[class*="sidebar"] button[class*="collapse"], which was meant for Mintlify's native collapse button. Mintlify's hosted renderer now putsw-(--sidebar-width,19rem)onnav#sidebar-content, so that selector matches every button in the sidebar whose class contains "collapse", including our own.ls-nav-collapse-btn. The rule setsdisplay: none !importanton our click target. The icon still shows because it is drawn by pseudo-elements on the theme switcher, so clicks fall through to the footerdiv..ls-nav-collapse-btnfrom that one selector with:not(.ls-nav-collapse-btn). The other hide rules are unchanged.Test plan
display: nonewith a 0×0 box and is absent from the accessibility tree.ls-nav-collapsedwas saved tolocalStorage.Made with Cursor