Skip to content

fix(docs): stop hiding the footer sidebar collapse button - #1148

Merged
patcapulong merged 1 commit into
mainfrom
pat/fix-sidebar-collapse-btn
Oct 9, 2026
Merged

patcapulong merged 1 commit into
mainfrom
pat/fix-sidebar-collapse-btn

Conversation

@patcapulong

Copy link
Copy Markdown
Contributor

The collapse button in the docs sidebar footer does nothing on production. The icon renders, but clicking it has no effect.

Our "hide sidebar controls" rule in mintlify/style.css includes [class*="sidebar"] button[class*="collapse"], which was meant for Mintlify's native collapse button. Mintlify's hosted renderer now puts w-(--sidebar-width,19rem) on nav#sidebar-content, so that selector matches every button in the sidebar whose class contains "collapse", including our own .ls-nav-collapse-btn. The rule sets display: none !important on our click target. The icon still shows because it is drawn by pseudo-elements on the theme switcher, so clicks fall through to the footer div.

  • Exempt .ls-nav-collapse-btn from that one selector with :not(.ls-nav-collapse-btn). The other hide rules are unchanged.

Test plan

  • On docs.lightspark.com, confirmed the button computes to display: none with a 0×0 box and is absent from the accessibility tree.
  • Applied the same selector change to the live stylesheet in the browser and clicked the footer icon with a real mouse. The sidebar collapsed to the 48px rail and ls-nav-collapsed was saved to localStorage.

Made with Cursor

…our own hide-native-controls rule

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
grid-cards-demo Ignored Ignored Preview Oct 9, 2026 5:29am UTC
grid-flow-builder Ignored Ignored Preview Oct 9, 2026 5:29am UTC
grid-wallet-demo Ignored Ignored Preview Oct 9, 2026 5:29am UTC

Request Review

@mintlify

mintlify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Grid 🟢 Ready View Preview Oct 9, 2026, 5:30 AM

@patcapulong

Copy link
Copy Markdown
Contributor Author

@greptileai

@patcapulong

Copy link
Copy Markdown
Contributor Author

@faraday review

@ls-bolt

ls-bolt Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

⚡ Running fastpass on this PR first (https://zeus.dev.dev.sparkinfra.net/#/instance?id=wired-actuator-ww). A full council convenes only if fastpass assesses the risk at critical or above. Post a new comment '@faraday full review' to convene one anyway.

@ls-bolt

ls-bolt Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

📌 Bolt Status

2026-10-09 05:29:49 UTC — ⚡ Agent wired-actuator-ww(#1) started


Feedback

@lightspark-faraday

Copy link
Copy Markdown

Faraday review

fastpass advisory - comment-only, never blocks a merge. To retire a finding, either fix it or reply explaining why it is wrong: a rebuttal gets an agree or disagree answer on the thread, and if you reply again after a disagreement we concede. Acknowledging it ("will fix") or resolving the thread does not retire it on its own. This comment is edited in place every round; inline findings still post as new comments each round.

Faraday score: 5/5 (clean) - 5 nothing blocking open | 4 non-blocking only | 3 one blocking open | 2 two | 1 a P0 or 3+ blocking; never drops without a new blocker

7d2507077eb1 | 0 inline + 0 in-body finding(s) (0 new) | 0 suggestion(s) | 0 refuted pre-post | route_deep: false | fail-open: 1 event (top: posting_filter_skipped)

🦕 Congratulations @patcapulong - you caught a Shantungosaurus! (common)

Shantungosaurus was one of the largest hadrosaurs known, reaching lengths rivaling some of the biggest carnivorous dinosaurs. Its fossils come from Shandong Province in China, which gives the genus its name.

View your collection: https://zeus.dev.dev.sparkinfra.net/#/dinodex/patcapulong

This summary supersedes the per-round summary blocks on the faraday reviews above; those are left in place as history and are not edited.

@greptile-apps

greptile-apps Bot commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low impact] This PR appears safe to merge.

Summary

Exempts .ls-nav-collapse-btn from the broad sidebar hide selector, restoring the footer’s click target.

  • Keeps the other hide selectors unchanged.
  • Adds a comment explaining why the hosted sidebar matched the old selector.
  • No actionable issues found.

Reviews (1) · Last reviewed commit: "fix(docs): the footer sidebar collapse b..." · Reviewed by Greptile

@patcapulong
patcapulong marked this pull request as ready for review October 9, 2026 05:35
@patcapulong
patcapulong enabled auto-merge (squash) October 9, 2026 05:52
@patcapulong
patcapulong merged commit db243cc into main Oct 9, 2026
8 checks passed
@patcapulong
patcapulong deleted the pat/fix-sidebar-collapse-btn branch October 9, 2026 06:03

This branch was successfully deployed

1 active deployment
staging - mintlify — 7d250707 Deployed Oct 9, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants