Skip to content

docs(cards): state physical cards are not offered - #941

Draft
ls-bolt[bot] wants to merge 1 commit into
mainfrom
09-10-AT-5454-drop-physical-card-wording
Draft

docs(cards): state physical cards are not offered#941
ls-bolt[bot] wants to merge 1 commit into
mainfrom
09-10-AT-5454-drop-physical-card-wording

Conversation

@ls-bolt

@ls-bolt ls-bolt Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Summary

POST /cards rejects any form other than VIRTUAL. The docs, however, still promised physical cards were coming, in two places:

  • The CardForm schema description: "Only VIRTUAL is supported in v1; PHYSICAL will be added in a later release."
  • The POST /cards field table in the issuing-cards guide: "VIRTUAL in v1. PHYSICAL will be added later."

Physical cards are not a supported product on the API, so both now say so.

Editing the source, not the bundle

An earlier pass at this wording was made against a downstream generated copy of the spec. Because that copy is regenerated from this repo, a later version bump reverted it. This change edits the source (openapi/components/schemas/cards/CardForm.yaml) so it survives regeneration.

Changes: 4 files

  • openapi/components/schemas/cards/CardForm.yaml — the source description (the only hand-edited spec file)
  • openapi.yaml, mintlify/openapi.yaml — regenerated by make build
  • mintlify/snippets/cards/issuing-cards.mdx — the form row of the POST /cards field table

No info.version bump: this is description-only, not a breaking change.

Test plan

Documentation-only repo, so no test suite applies.

  • make build — rebundles cleanly; both generated bundles carry the new text.
  • make lint — exits 0, with exactly the pre-change counts (2 warnings, 14 explicitly ignored). No new lint problems.
  • Confirmed the enum itself is untouched (VIRTUAL only), and that no other page contradicts the change: the card-design pages describe physical cards as an out-of-band program arranged during onboarding, and already state "The Cards API issues virtual cards."

Requested by @AaryamanBhute

The Grid API rejects any form other than VIRTUAL, but the CardForm
description and the issuing-cards field table still promised PHYSICAL in a
later release.

Co-Authored-By: AaryamanBhute <AaryamanBhute@users.noreply.github.com>
@mintlify

mintlify Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Grid 🟢 Ready View Preview Sep 10, 2026, 7:15 PM

@ls-bolt ls-bolt Bot added the bolt label Sep 10, 2026
@vercel

vercel Bot commented Sep 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
grid-flow-builder Ignored Ignored Preview Sep 10, 2026 7:13pm UTC
grid-wallet-demo Ignored Ignored Preview Sep 10, 2026 7:13pm UTC

Request Review

@ls-bolt

ls-bolt Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

@greptile review

Copy link
Copy Markdown

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli
⏳ (generating...)```
docs(cards): state physical cards are not offered

**go**
⏳ (generating...)```
docs(cards): state physical cards are not offered

kotlin
⏳ (generating...)```
docs(cards): state physical cards are not offered

**openapi**
⏳ (generating...)```
docs(cards): state physical cards are not offered

php
⏳ (generating...)```
docs(cards): state physical cards are not offered

**python**
⏳ (generating...)```
docs(cards): state physical cards are not offered

ruby
⏳ (generating...)```
docs(cards): state physical cards are not offered

**typescript**
⏳ (generating...)```
docs(cards): state physical cards are not offered

Edit this comment to update them. They will appear in their respective SDK's changelogs.

grid-typescript studio
grid-openapi studio
grid-ruby studio
grid-kotlin studio
grid-go studio
grid-python studio
grid-php studio
grid-cli studio

⏳ These are partial results; builds are still running.


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-09-10 19:24:56 UTC

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge because its documentation now matches the VIRTUAL-only request schema and all generated contract copies remain synchronized.

Summary

  • Clarifies that CardForm supports only VIRTUAL.
  • States that POST /cards rejects other form values.
  • Keeps the modular source and both generated OpenAPI bundles synchronized.
  • Leaves the API shape and version unchanged.

Reviews (1) · Last reviewed commit: "docs(cards): state physical cards are no..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants