docs(cards): diagram the card transaction status transitions - #961
Open
whoisglover wants to merge 1 commit into
Open
docs(cards): diagram the card transaction status transitions#961whoisglover wants to merge 1 commit into
whoisglover wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
Contributor
Author
|
@greptile review |
Contributor
|
whoisglover
force-pushed
the
eng-11670-transaction-state-diagram
branch
from
September 12, 2026 03:55
2abf9a1 to
da0ece8
Compare
whoisglover
marked this pull request as ready for review
September 12, 2026 03:56
Contributor
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: ENG-11670 under ENG-11645
What this does
The reconciliation page explains how a card transaction moves between statuses. It draws those transitions as an ASCII block.
The block has fallen behind the model. It shows no path out of
PARTIALLY_SETTLEDintoEXCEPTION, even though a pull can fail at any point after the authorization, and no path out ofEXCEPTIONat all. It also says nothing about reversals or expiries, which is the question integrators actually ask.This PR replaces it with a state diagram and writes down the two rules the old block left out.
How it works
stateDiagram-v2, matching the one on the transaction lifecycle page.EXCEPTION, and the way back out of it.EXCEPTIONis drawn with a way out.authorizedAmount, and leaves the transactionAUTHORIZED. A full reversal or an expiry releases the whole hold, so the transaction resolves asSETTLEDwith asettledAmountof zero.Every claim is read off
_gen_derive_current_statusinent_grid_card_transaction_schema.py, not inferred from the old docs.EXCEPTIONtoSETTLEDis the credit path: a credit whose authorization was refused derivesEXCEPTION, and once the return posts it derivesSETTLED.Tests
Docs only. No spec change, so no rebundle.
make lintis unaffected.History
This is the last piece of #935, which was merged into #934's branch by mistake instead of into
main. TheDECLINEDstatus from that PR shipped separately in #957, and the decline reason is in #960.