Repository navigation
feat(cards): add VOIDED card transaction status - #993
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
✱ Stainless preview builds for gridThis PR will update the cli go kotlin openapi php python ruby typescript
|
|
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@greptileai review |
|
@codex review |
|
@faraday review |
|
⚡ Running fastpass on this PR first (https://zeus.dev.dev.sparkinfra.net/#/instance?id=throbbing-keysend). A full council convenes only if fastpass assesses the risk at critical or above. Post a new comment '@faraday full review' to convene one anyway. |
|
📌 Bolt Status 2026-09-14 19:37:41 UTC — ⚡ Agent |
There was a problem hiding this comment.
Findings without a diff anchor:
P2 mintlify/changelog.mdx:40 - The changelog still says card-transaction status tracks settlement only, contradicting the newly documented authorization-outcome statuses.
Lines 24-30 define DECLINED and VOIDED for declined or reversed authorizations, while line 40 says "A card transaction's status tracks settlement only." Clients reading the same release note receive incompatible descriptions of what the status represents.
No diff anchor, so there is no thread to reply on. To dismiss this finding, comment on the PR: fastpass dismiss 07b29a4d
P2 openapi.yaml - Generator inputs (source schemas under openapi/) changed to add VOIDED, and the openapi.yaml/mintlify/openapi.yaml bundles were regenerated, but no downstream generated API client in the repo was regenerated alongside them, so any checked-in client SDK may now be out of sync with the new VOIDED enum value.
GENERATED CODE FACTS: "generator inputs changed (mintlify/openapi.yaml, openapi.yaml) but no a regenerated API client changed in this PR - regeneration may be missing (12 non-input changed file(s) were checked at head for a generated-file header marker... none is generator output)".
No diff anchor, so there is no thread to reply on. To dismiss this finding, comment on the PR: fastpass dismiss 84de81e3
Faraday reviewfastpass advisory - comment-only, never blocks a merge. To retire a finding, either fix it or reply explaining why it is wrong: a rebuttal gets an agree or disagree answer on the thread, and if you reply again after a disagreement we concede. Acknowledging it ("will fix") or resolving the thread does not retire it on its own. This comment is edited in place every round; inline findings still post as new comments each round. Faraday score: 4/5 (P2/P3 findings) - 5 nothing blocking open | 4 non-blocking only | 3 one blocking open | 2 two | 1 a P0 or 3+ blocking; never drops without a new blocker Still open:
fastpass re-review: 3 new finding(s). This summary supersedes the per-round summary blocks on the faraday reviews above; those are left in place as history and are not edited. |
|
@codex review |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@greptileai review |
|
Faraday in-body findings:
fastpass dismiss 84de81e3 |
|
@codex review |
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@greptileai review |
|
@codex review |
Jira: AT-6592
Follow-up contract for webdev #34889.
What this does
Adds the terminal
VOIDEDcard transaction status and matchingCARD_TRANSACTION.VOIDEDwebhook event.DECLINEDmeans the authorization was refused before approval.VOIDEDmeans an approved authorization was fully reversed or expired before any clearing posted, withauthorizedAmount: 0and nosettledAmount.SETTLEDmeans clearing posted.The source schemas, generated OpenAPI bundles, and the three card lifecycle snippets now describe the same contract.
Verification
make buildmake lint