Merge sidebar Settings into a 900px SbModal - #19
Merged
Merged
Conversation
Inventory both current settings UIs and specify a single top-right global entry that opens a 900px modal. Plan only; no product code. Co-authored-by: linkxzhou <zhoulv2000@163.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
linkxzhou
marked this pull request as ready for review
September 21, 2026 12:01
cursor
Bot
changed the title
This was referenced Sep 21, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges sidebar Settings and the header connection drawer into one top-right
SbModal(maxWidth: 900).Plan
plan/planv2.0/ui-settings-merge-plan.mdupdated for the review decisions:SbModal(extend withmaxWidth/minWidth/hideFooter) — no extra Dialog shell.ApiKeyDrawer(Sheet-based settings) and the full-page/settingsview.Implementation
SettingsModal(SbModal+ tabs: 连接 / 外观 / 模型 / 供应商)./settingsredirects to/?settings=1and opens the same modal.settingsOpen/openSettings/closeSettings(drawer APIs removed).Verify
Then
VITE_USE_MOCK=true yarn dev, click the top-right gear, confirm sidebar has no 设置, and visit/settings.Tests
yarn test: 190 passed.yarn buildsucceeds.