fix(ui): stack Tabs content below the tab list - #22
Merged
Merged
Conversation
Tailwind's data-horizontal: variant looks for a boolean data-horizontal attribute, but Tabs sets data-orientation="horizontal". Horizontal tabs therefore never stacked (flex-col), so Settings modal tabs sat beside content instead of above it. Co-authored-by: linkxzhou <zhoulv2000@163.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
linkxzhou
marked this pull request as ready for review
September 21, 2026 12:53
cursor Bot
pushed a commit
that referenced
this pull request
Sep 21, 2026
Resolve PR #20 conflicts by taking main for settings UI (PR #21 modal merge and PR #22 Tabs orientation already landed) and keeping main's complete settings-merge plan (SbModal maxWidth/minWidth 900px, ApiKeyDrawer removal). Drop the superseded AppSettingsPanel in favor of SettingsPanel. Co-authored-by: linkxzhou <zhoulv2000@163.com>
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Settings modal tabs rendered side-by-side with content instead of a top tab bar with content below.
Tabs.vuesetsdata-orientation="horizontal"(the reka-ui convention), but the layout classes used Tailwind’sdata-horizontal:variant. That variant matches a booleandata-horizontalattribute, notdata-orientation="horizontal", soflex-colnever applied. The same mismatch brokeTabsList/TabsTriggerunderline styles (group-data-horizontal/tabs:/group-data-vertical/tabs:).Fix
Use selectors that match the existing
data-orientationattribute:data-[orientation=horizontal]:flex-colon the tabs rootgroup-data-[orientation=horizontal]/tabs:/group-data-[orientation=vertical]/tabs:on list and triggerNo Settings IA / tab structure changes.
Tests
ui/src/components/ui/tabs/tabs.test.tsclass-string / mount assertions for the orientation selectors.npx vitest run src/components/ui/tabs/tabs.test.tspasses.Verification
Browser-checked the Settings modal on the running UI:
[data-slot=tabs]hasdata-orientation="horizontal"and computedflex-direction: columnstacked: true) on 连接 / 外观 / 模型 / 供应商