Skip to content

simpleclient: Preserve the "#auto" install marker through local depen… #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexB7 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

simpleclient: Preserve the "#auto" install marker through local depen… #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions aptkit/simpleclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ def install_packages(self, packages, use_apt_resolver=True):
# Use the resolver from python-apt
# it works better in complex scenarios
# mark the packages as mark_install
# Package names may carry an explicit "#auto" suffix (see
# aptworker._mark_packages_for_installation()) telling the worker to
# record them as automatically installed rather than manual. Strip it
# for the cache lookups below, since apt itself doesn't know about it.
requested_names = [name.partition("#")[0] for name in packages]
cache = apt.Cache()
for name in packages:
for name in requested_names:
try:
pkg = cache[name]
pkg.mark_install()
Expand All @@ -55,8 +60,12 @@ def install_packages(self, packages, use_apt_resolver=True):
# via cache.get_changes()
changes = cache.get_changes()
for pkg in changes:
if pkg.marked_install and pkg.name not in packages:
packages.append(pkg.name)
if pkg.marked_install and pkg.name not in requested_names:
# Not explicitly requested, just pulled in as a dependency
# (e.g. a kernel image pulled in by a meta package): flag it
# as automatic so it stays eligible for autoremoval, same as
# a normal "apt install"/"apt upgrade" would leave it.
packages.append(pkg.name + "#auto")

@randomnoise randomnoise Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, exact duplicate of

@AlexB7 AlexB7 Aug 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, exact duplicate of

Yes but with some more logic and it's needed for linuxmint/mintupdate#1081.


client = aptkit.client.AptClient()
client.install_packages(packages, reply_handler=self._simulate_trans, error_handler=self._on_error)
Expand Down