Skip to content

Adding label to discover service monitor for prometheus. #97

Description

@Q00

Hi. I deployed livekit using eks and configured monitoring.
But there was an issue between Prometheus and service monitor. Prometheus can not find the service monitor.
Prometheus check a label which is 'release=prometheus' in the service monitor.
But livekit-server helm chart doesn't make this label.
Please check this helpers code in livekit-helm repository.

I edited service monitor and added the line with release=prometheus and then Prometheus can find the service monitor.

image image

Can I make the PR which add line 'release=prometheus' in service monitor labels if prometheus_port is specified in values.yml?

I used this options.

replicaCount: 2

# Suggested value for gracefully terminate the pod: 5 hours
livekit:
  port: 7880
  log_level: info
  rtc:
    ...
  redis:
    ...
  keys:
    ...
  prometheus_port: 6789
  turn:
    enabled: true
    ...
loadBalancer:
  type: disable

autoscaling:
  ...

resources:
  ...
serviceMonitor:
  create: true
  annotations: {
    "prometheus.io/scrape": "true",
    "prometheus.io/path": "/metrics",
    "prometheus.io/port": "6789"
  }
  name: "prometheus-operator"
  interval: 30s

This is my infrastructure
image

Activity

  1. hocmemini commented on Apr 28, 2026

    @hocmemini

    Hi @Q00, opened a PR (#160) that adds the serviceMonitor.labels field you proposed. The implementation matches what you described in your original issue, with the addition that it works on any custom labels (not just release=prometheus), so operators using non-default Prometheus serviceMonitorSelector configurations can still discover the ServiceMonitor. Tests cover the kube-prometheus-stack case explicitly. Thanks for the clear writeup of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions