TEL-717: ack/bye to 200 ok after cancel - #756
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
Author
|
not related to this change, but it seems we have some flaky tests https://github.com/livekit/sip/actions/runs/30114193566/attempts/1?pr=756 |
alexlivekit
requested changes
Jul 28, 2026
Contributor
There was a problem hiding this comment.
If 200 ok arrives after cancel, we should ACK and BYE.
If this is an outbound call, only we can be sending CANCEL requests, and these should be rejected/dropped. If the remote party wants to reject an incoming (lk -> remote) call, they can simply respond with a >=400 status code.
What is this trying to fix exactly?
alexlivekit
approved these changes
Jul 28, 2026
alexlivekit
left a comment
alexlivekit
left a comment
Contributor
There was a problem hiding this comment.
I stand corrected, we absolutely need to ACK & BYE the call if we want to abort, but receive a 200.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cancel and 200 ok is a common race. If 200 ok arrives after cancel, we should ACK and BYE.