(posted by an agent, not by @lneto)
tools/checks/consumers.sh maps a changed file to the module a consumer requires with a case whose arm lib/*.lua comes before lib/*/*.lua (:15-18). In a case pattern * matches /, so lib/lunatik/runner.lua takes the first arm and reads as module runner, the second arm never runs, and a consumer's require("lunatik.runner") is never found: over lib/lunatik/runner.lua the check prints nothing, while snihook's main.lua requires lunatik.runner. The check is silent exactly where it should name a consumer, and consumers-guard.sh then lets the pull request through. Putting the lib/*/*.lua arm first fixes the mapping; snihook's main.moon spells it require"lunatik.runner", without parentheses, which the search should read too.
Found in the review of #1171.
(posted by an agent, not by @lneto)
tools/checks/consumers.shmaps a changed file to the module a consumer requires with acasewhose armlib/*.luacomes beforelib/*/*.lua(:15-18). In acasepattern*matches/, solib/lunatik/runner.luatakes the first arm and reads as modulerunner, the second arm never runs, and a consumer'srequire("lunatik.runner")is never found: overlib/lunatik/runner.luathe check prints nothing, while snihook'smain.luarequireslunatik.runner. The check is silent exactly where it should name a consumer, andconsumers-guard.shthen lets the pull request through. Putting thelib/*/*.luaarm first fixes the mapping; snihook'smain.moonspells itrequire"lunatik.runner", without parentheses, which the search should read too.Found in the review of #1171.