chore: switch to released xmi 0.7.0, drop compatibility guard - #34
Merged
Conversation
xmi 0.7.0 is live on RubyGems (published today, tag v0.7.0), so the temporary compatibility scaffolding is no longer needed: - Gemfile: remove the companion-branch pin (feat/nested-classifier- mapping); xmi now resolves from RubyGems in CI and gem installs. - ea.gemspec: tighten xmi dependency from ">= 0.6.2" to "~> 0.7". Bundler now enforces the real floor; no silent nested-class loss is possible on any resolvable version. - Delete lib/ea/xmi_guard.rb and its require in lib/ea.rb. The boot-time guard existed only to turn silent data loss into a loud error while 0.6.x satisfied the loose floor; with "~> 0.7" the constraint does that job. Verified locally in both resolution modes: - EA_FORCE_RUBYGEMS=1: xmi 0.7.0 from RubyGems, nested_classifier defined, basic.qea export produces 130 packagedElements. - Sibling-path mode: full suite 2331 examples, 0 failures (4 guard specs removed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xmi 0.7.0 is live on RubyGems (tag v0.7.0, published today). This completes the post-release cleanup that #33 planned for in its own comments:
lutaml/xmifeat/nested-classifier-mapping); xmi now resolves from RubyGems in CI and for gem installs.xmifrom>= 0.6.2to~> 0.7. Bundler now enforces the real floor, so silent nested-class loss is impossible on any resolvable version.lib/ea/xmi_guard.rband itsrequireinlib/ea.rb(plus its spec). The boot-time guard existed only to turn silent data loss into a loud error while 0.6.x still satisfied the loose floor; with~> 0.7the constraint itself does that job.Also removes the guard's use of
method_defined?, which is on this repo's banned-patterns list.Verification
Both resolution modes tested locally:
EA_FORCE_RUBYGEMS=1: lock resolves xmi 0.7.0 from RubyGems,Xmi::Uml::PackagedElement#nested_classifieris defined, basic.qea export produces 130 packagedElements.Test plan
bundle exec rspec— 2331 examples, 0 failuresEA_FORCE_RUBYGEMS=1