Repository navigation
Fix Robometer RFM tokenizer and processor parity - #4
Hynek Kydlíček (hynky1999) merged 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3694502539
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| @@ -257,6 +269,11 @@ def cached_tokenizer_from_config(model_config: "ModelConfig", **kwargs): | |||
| if model_config.skip_tokenizer_init: | |||
| return None | |||
|
|
|||
| if "RFM" in getattr(model_config.hf_config, "architectures", ()): | |||
There was a problem hiding this comment.
Handle null architectures before tokenizer caching
For models whose HF config sets architectures explicitly to None, this check raises TypeError: argument of type 'NoneType' is not iterable before any tokenizer can be loaded; getattr(..., ()) only covers the attribute being absent, not the common explicit-null case (there are existing vLLM test configs with architectures=None). This makes unrelated non-RFM models fail during cached_tokenizer_from_config; coerce with getattr(..., None) or () before the membership test.
Useful? React with 👍 / 👎.
| if not uses_hma: | ||
| port: int | ||
| with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s: | ||
| s.bind(("0.0.0.0", 0)) |
|
|
||
| port: int | ||
| with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s: | ||
| s.bind(("0.0.0.0", 0)) |
|
|
||
| port: int | ||
| with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s: | ||
| s.bind(("0.0.0.0", 0)) |
3694502 to
7e0833b
Compare
Co-authored-by: OpenAI Codex Signed-off-by: Hynek Kydlicek <kydlicek.hynek@gmail.com>
7e0833b to
7e9f476
Compare
d3bb529
into
codex/sync-upstream-main
Summary
Fix Robometer/RFM parity by:
step_tag_idto the official<|prog_token|>id151673Qwen3VLProcessorper requestThis keeps the fix scoped to RFM/Robometer and removes the per-request processor reload that caused slow
/poolingbursts.Validation
uvx ruff check vllm/model_executor/models/config.py vllm/model_executor/models/rfm.py vllm/tokenizers/hf.py vllm/tokenizers/registry.py --ignore SIM910git diff --check HEADap-VMBp6Wp2qPMVte91vZKIqWap-zc4qWvAwmBLYz9byAaUdbp0.00186511484157969590.0029832334522436367ap-l1doOmDvRacBKeqDVDHDe716.83s90ms122msFocused pytest was not run locally because this checkout's
.venvdoes not havepytestinstalled.Duplicate Check
Checked open PRs in
macrodata-labs/vllmfor:RFM Robometer special tokensRobometer step_tag_idNo matching open PRs were found.
AI assistance was used to prepare this change.