Alive check - #4600
Open
CarensirA-MF wants to merge 5 commits into
Open
Alive check#4600CarensirA-MF wants to merge 5 commits into
CarensirA-MF wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My understanding web liveness probe was kind of answering the wrong question. It hits
/landing/, which needs Redis, the database pool and a template render, so it reports "is Postgres fast right now?" when the cluster aganet is asking "would restarting this process help?".Based on the opservastions (via k9s) every pod was blocked on the same exhausted pool, every probe failed within the same minute, and restarted the web pods in a wave. Each restart dropped in-flight requests and took up to 200 s to return, while the remaining pods absorbed the load.
What changes
/aliveon Root, withtools.sessions,tools.oidcandtools.reset_threadlocaloff for the path, the same exemptions the static paths use. No template render either way.liveness_checks_dependencies, default on:/alivepings Redis through the session client and runsSELECT 1on a pooled connection. Either failing returns 503. Under pool exhaustion the connection checkout waits the pool timeout, which exceeds the probe timeout, so a stuck pod fails the probe and is restarted. That matches the current behavior minus the page render.Off:
/alivereturns 200 as long as CherryPy can hand the request to a thread.