docs: add scoped protocol runtime failure contracts - #11
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8e0964289
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## 1. Core authority | ||
|
|
||
| Core owns byte-level FT1.2/link/ASDU decoding, protocol primitives, mapping primitives, and offline analysis semantics. UI and Master may consume Core results; they must not duplicate parser truth. |
There was a problem hiding this comment.
Limit parser ownership to the protocols Core implements
This unqualified ownership statement conflicts with the repository's existing architecture: docs/ARCHITECTURE.md:61-75 assigns IEC-10x ASDU and IEC-104 APDU parsing to Master, where Protocol/Iec10x/Iec10xAsduDecoder.cs and Iec104ApduParser.cs already provide the canonical implementations. As written, future work on those parsers is simultaneously required to remain in Master and prohibited as duplicated parser truth; qualify this contract as IEC-103/Core-hosted parsing, or migrate the IEC-10x parsers and architecture documentation together.
Useful? React with 👍 / 👎.
Summary
Adds narrowly scoped engineering contracts beneath the existing mature root
AGENTS.md; the root contract is not rewritten.src/ARIEC60870.Master/AGENTS.mdsrc/ARIEC60870.Core/AGENTS.mdDocumentation-only change; protocol/runtime behavior is unchanged.